From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Ingo van Lil <inguin@gmx.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Rosin <peda@axentia.se>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: Reenable UART TX pull-ups
Date: Tue, 10 Dec 2019 11:57:19 +0100 [thread overview]
Message-ID: <20191210105719.GF1463890@piout.net> (raw)
In-Reply-To: <20191203142147.875227-1-inguin@gmx.de>
On 03/12/2019 15:21:47+0100, Ingo van Lil wrote:
> Pull-ups for SAM9 UART/USART TX lines were disabled in a previous
> commit. However, several chips in the SAM9 family require pull-ups to
> prevent the TX lines from falling (and causing an endless break
> condition) when the transceiver is disabled.
>
> From the SAM9G20 datasheet, 32.5.1: "To prevent the TXD line from
> falling when the USART is disabled, the use of an internal pull up
> is mandatory.". This commit reenables the pull-ups for all chips having
> that sentence in their datasheets.
>
> Fixes: 5e04822f7db5 ("ARM: dts: at91: fixes uart pinctrl, set pullup on rx, clear pullup on tx")
> Signed-off-by: Ingo van Lil <inguin@gmx.de>
> Cc: Peter Rosin <peda@axentia.se>
> ---
> arch/arm/boot/dts/at91sam9260.dtsi | 12 ++++++------
> arch/arm/boot/dts/at91sam9261.dtsi | 6 +++---
> arch/arm/boot/dts/at91sam9263.dtsi | 6 +++---
> arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++++----
> arch/arm/boot/dts/at91sam9rl.dtsi | 8 ++++----
> 5 files changed, 20 insertions(+), 20 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-10 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 14:21 [PATCH] ARM: dts: at91: Reenable UART TX pull-ups Ingo van Lil
2019-12-10 10:57 ` Alexandre Belloni [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-28 10:06 Ingo van Lil
2019-12-03 13:04 ` Peter Rosin
2019-12-03 13:22 ` Ingo van Lil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210105719.GF1463890@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=inguin@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox