The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: kernel test robot <rong.a.chen@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
	David Howells <dhowells@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org
Subject: Re: [pipe] 3c0edea9b2: lmbench3.PIPE.bandwidth.MB/sec -17.0% regression
Date: Tue, 10 Dec 2019 22:15:02 +0800	[thread overview]
Message-ID: <20191210141502.GQ32275@shao2-debian> (raw)
In-Reply-To: <CAHk-=whF0mbvWC=sYKWTrpymmjWkGZcX9hnHgnm1t1M++W66zA@mail.gmail.com>

On Mon, Dec 09, 2019 at 10:35:35AM -0800, Linus Torvalds wrote:
> On Mon, Dec 9, 2019 at 12:56 AM Michal Hocko <mhocko@kernel.org> wrote:
> >
> > Huh. How can something like that can even can get merged? No changelog,
> > no s-o-b?
> 
> Yeah, I missed that when pulling.
> 
> I wish that had been the only problem we had with that code, but it wasn't.
> 
> Anyway, I'm fairly certain the current git head should fix this
> lmbench3 performance regression too.
> 
>                    Linus

Hi Linus,

Sorry for the inconvenience, indeed, the regression has been fixed.

commit:
  cefa80ced5 ("pipe: Increase the writer-wakeup threshold to reduce context-switch count")
  3c0edea9b2 ("pipe: Remove sync on wake_ups")
  6794862a16 ("Merge tag 'for-5.5-rc1-kconfig-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux")

cefa80ced57a2917  3c0edea9b29f9be6c093f236f7  6794862a16ef41f753abd75c03  testcase/testparams/testbox
----------------  --------------------------  --------------------------  ---------------------------
         %stddev      change         %stddev      change         %stddev
             \          |                \          |                \  
     21204             -17%      17604              23%      26123 ±  3%  lmbench3/performance-development-100%-PIPE-50%-ucode=0x7000019/lkp-bdw-de1
     21204             -17%      17604              23%      26123        GEO-MEAN lmbench3.PIPE.bandwidth.MB/sec

Best Regards,
Rong Chen

  reply	other threads:[~2019-12-10 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-08 15:39 [pipe] 3c0edea9b2: lmbench3.PIPE.bandwidth.MB/sec -17.0% regression kernel test robot
2019-12-09  8:55 ` Michal Hocko
2019-12-09 18:35   ` Linus Torvalds
2019-12-10 14:15     ` kernel test robot [this message]
2019-12-10 17:52       ` Linus Torvalds
2019-12-11 14:52         ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210141502.GQ32275@shao2-debian \
    --to=rong.a.chen@intel.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=mhocko@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox