Re: [PATCH 08/10] tty: serial: samsung_tty: use 'unsigned int' not 'unsigned'

Greg Kroah-Hartman
2019-12-12T11:08:38Z

On Tue, Dec 10, 2019 at 04:12:07PM +0100, Marc Gonzalez wrote:
> [ Trim recipients list ]
>
> On 10/12/2019 15:37, Greg Kroah-Hartman wrote:
>
> > The function uart_console_write() expects an unsigned int, so use that
> > variable type, not 'unsigned', which is generally frowned apon in the
> > kernel now.
>
> "frowned upon"
>
> Wait, what?!
>
> 'unsigned' and 'unsigned int' are the same type, if I remember my C
> lessons correctly.
>
> Is this a uniformization issue?

Yes. It's a long-time checkpatch warning, it's good to be explicit for
this type of thing.

thanks,

greg k-h