From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>, Joe Perches <joe@perches.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] staging: hp100: add back CONFIG_NET dependency
Date: Tue, 10 Dec 2019 21:13:18 +0100 [thread overview]
Message-ID: <20191210201318.GA4070187@kroah.com> (raw)
In-Reply-To: <20191210200110.994059-1-arnd@arndb.de>
On Tue, Dec 10, 2019 at 09:00:52PM +0100, Arnd Bergmann wrote:
> The move to staging lost an important dependency:
>
> ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!
>
> Add it back explicitly.
>
> Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/hp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig
> index fb395cfe6b92..9566d4ab5ce5 100644
> --- a/drivers/staging/hp/Kconfig
> +++ b/drivers/staging/hp/Kconfig
> @@ -6,6 +6,7 @@
> config NET_VENDOR_HP
> bool "HP devices"
> default y
> + depends on NET
> depends on ISA || EISA || PCI
> ---help---
> If you have a network (Ethernet) card belonging to this class, say Y.
Heh, I just queued up this same patch a few hours ago :)
greg k-h
prev parent reply other threads:[~2019-12-10 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 20:00 [PATCH] staging: hp100: add back CONFIG_NET dependency Arnd Bergmann
2019-12-10 20:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210201318.GA4070187@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox