* [PATCH] staging: hp100: add back CONFIG_NET dependency
@ 2019-12-10 20:00 Arnd Bergmann
2019-12-10 20:13 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2019-12-10 20:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Joe Perches, Jaroslav Kysela, David S. Miller,
devel, linux-kernel
The move to staging lost an important dependency:
ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!
Add it back explicitly.
Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/hp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig
index fb395cfe6b92..9566d4ab5ce5 100644
--- a/drivers/staging/hp/Kconfig
+++ b/drivers/staging/hp/Kconfig
@@ -6,6 +6,7 @@
config NET_VENDOR_HP
bool "HP devices"
default y
+ depends on NET
depends on ISA || EISA || PCI
---help---
If you have a network (Ethernet) card belonging to this class, say Y.
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: hp100: add back CONFIG_NET dependency
2019-12-10 20:00 [PATCH] staging: hp100: add back CONFIG_NET dependency Arnd Bergmann
@ 2019-12-10 20:13 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-10 20:13 UTC (permalink / raw)
To: Arnd Bergmann
Cc: devel, linux-kernel, Jaroslav Kysela, Joe Perches,
David S. Miller
On Tue, Dec 10, 2019 at 09:00:52PM +0100, Arnd Bergmann wrote:
> The move to staging lost an important dependency:
>
> ERROR: "eth_validate_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_mac_addr" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "alloc_etherdev_mqs" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "register_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__skb_pad" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "consume_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "dev_trans_start" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__dev_kfree_skb_any" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "netif_rx" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "eth_type_trans" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_trim" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "skb_put" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "__netdev_alloc_skb" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "free_netdev" [drivers/staging/hp/hp100.ko] undefined!
> ERROR: "unregister_netdev" [drivers/staging/hp/hp100.ko] undefined!
>
> Add it back explicitly.
>
> Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/hp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig
> index fb395cfe6b92..9566d4ab5ce5 100644
> --- a/drivers/staging/hp/Kconfig
> +++ b/drivers/staging/hp/Kconfig
> @@ -6,6 +6,7 @@
> config NET_VENDOR_HP
> bool "HP devices"
> default y
> + depends on NET
> depends on ISA || EISA || PCI
> ---help---
> If you have a network (Ethernet) card belonging to this class, say Y.
Heh, I just queued up this same patch a few hours ago :)
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-10 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 20:00 [PATCH] staging: hp100: add back CONFIG_NET dependency Arnd Bergmann
2019-12-10 20:13 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox