From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D91C43603 for ; Tue, 10 Dec 2019 21:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80908206D5 for ; Tue, 10 Dec 2019 21:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576013419; bh=QPjFK2EXgY9x+qBNXW4gGPYCxWQ3fUnbQphCK0+D+ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=w2jqxiKEEdyjdjKGrwYoSrQBN2RrYFl0Dmw9RtOQRXTjp8dU2zsnLsQFiAo2EWPe6 +hfqnu5wJm5S0DRHejrRsMNNsUEKrXmmYo0u4YkeNE70aBJOof3toAia0HfDTmwYCh 6/JCMmYktLYP+zj6vmIPyahYkMHByCPlWa3HpX/k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728696AbfLJVaS (ORCPT ); Tue, 10 Dec 2019 16:30:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:59154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728314AbfLJVJ4 (ORCPT ); Tue, 10 Dec 2019 16:09:56 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E2FB246A2; Tue, 10 Dec 2019 21:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576012196; bh=QPjFK2EXgY9x+qBNXW4gGPYCxWQ3fUnbQphCK0+D+ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aE9NrNRHOmbOBO21R+xfWEkfVV7Wy6tk7hIEJcA5SVc8qkj1fId1FsDg159G6Pmqt oXi12gKq+h+Mhbc5Zft3sv61R8ERKOflvaB4Rl9EXxnAJqzwUPNX86MDJcMomMIF0w /bmbYpFm1kkk27PJ/QUmze2MFjPY1G2z+YIRh7qM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuhong Yuan , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 150/350] media: st-mipid02: add a check for devm_gpiod_get_optional Date: Tue, 10 Dec 2019 16:04:15 -0500 Message-Id: <20191210210735.9077-111-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210210735.9077-1-sashal@kernel.org> References: <20191210210735.9077-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 61c03b631b74a38ab53753f3ee971a55886d4843 ] mipid02_probe misses a check for devm_gpiod_get_optional and may miss the failure. Add a check to fix the problem. Signed-off-by: Chuhong Yuan Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/st-mipid02.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/st-mipid02.c b/drivers/media/i2c/st-mipid02.c index 81285b8d5cfbe..003ba22334cdf 100644 --- a/drivers/media/i2c/st-mipid02.c +++ b/drivers/media/i2c/st-mipid02.c @@ -971,6 +971,11 @@ static int mipid02_probe(struct i2c_client *client) bridge->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(bridge->reset_gpio)) { + dev_err(dev, "failed to get reset GPIO\n"); + return PTR_ERR(bridge->reset_gpio); + } + ret = mipid02_get_regulators(bridge); if (ret) { dev_err(dev, "failed to get regulators %d", ret); -- 2.20.1