From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EA9C43603 for ; Tue, 10 Dec 2019 22:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 798ED207FF for ; Tue, 10 Dec 2019 22:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576015898; bh=Z+gxcSRBALymU/z+rCEXW7uPIV+JARB6XxH9QYktmxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZvlLZ9MzXmTz+XWSH9jv46UfmBMuxtDzxtbcGZ8dLSFV65iQWRBWhcxiXT6dXraoY 49x96jye/w52/kTC8abS2y/p175T9Y5BdV299iYynQd/cheo9+VCqpK7Wx3ULHVWWf ocAvzNRlUA+nrpqW/WOFyWu/AtwXDFWqUCntqhe0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbfLJWD5 (ORCPT ); Tue, 10 Dec 2019 17:03:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:34066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbfLJWDp (ORCPT ); Tue, 10 Dec 2019 17:03:45 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C59452077B; Tue, 10 Dec 2019 22:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576015424; bh=Z+gxcSRBALymU/z+rCEXW7uPIV+JARB6XxH9QYktmxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rUfKPAt1x+gXQRes2raQrjBxDgPtDIdhW3ymQewWgt9f0wif3ziE8tEaWxyMakrID OCUN1Bh3TYRFIe/oA8MHSjRX6WiKEvmaEPEYEUsuCNID/GzBbGXP7nv225OQVkVAqw x6kBQIZmHUwzRXSmUfgvOoU+Cd2NX7cPHrg/aJ68= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Benoit Parrot , Tomi Valkeinen , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 036/130] media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence number Date: Tue, 10 Dec 2019 17:01:27 -0500 Message-Id: <20191210220301.13262-36-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210220301.13262-1-sashal@kernel.org> References: <20191210220301.13262-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benoit Parrot [ Upstream commit 2444846c0dbfa4ead21b621e4300ec32c90fbf38 ] v4l2-compliance fails with this message: fail: v4l2-test-buffers.cpp(294): \ (int)g_sequence() < seq.last_seq + 1 fail: v4l2-test-buffers.cpp(740): \ buf.check(m2m_q, last_m2m_seq) fail: v4l2-test-buffers.cpp(974): \ captureBufs(node, q, m2m_q, frame_count, true) test MMAP: FAIL The driver is failing to update the source frame sequence number in the vb2 buffer object. Only the destination frame sequence was being updated. This is only a reporting issue if the user space app actually cares about the frame sequence number. But it is fixed nonetheless. Signed-off-by: Benoit Parrot Reviewed-by: Tomi Valkeinen Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 4dc08f5a60811..8a5c0d3e733e1 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -1448,6 +1448,7 @@ static irqreturn_t vpe_irq(int irq_vpe, void *data) d_vb->timecode = s_vb->timecode; d_vb->sequence = ctx->sequence; + s_vb->sequence = ctx->sequence; d_q_data = &ctx->q_data[Q_DATA_DST]; if (d_q_data->flags & Q_IS_INTERLACED) { -- 2.20.1