From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C428C2BD09 for ; Wed, 11 Dec 2019 07:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61D23214D8 for ; Wed, 11 Dec 2019 07:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576048075; bh=8msHcIRu3PefYDklXS+Yt8ZWDv8UpIyQUU1KePcXvUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2Hk3g//Zs9Zl1tT2dEz54pNAgRAyn6+p+Ki0QZw9Qo9bS+l53uQcHtZ8a6G2/veay KpNE1Z5r4bsyIR90Db2QBuDBCs7tnn327bonUxl017IlX2cedkc4ACSHo4t55GFe3t 02aHdtygqAOZcBtEfynVWpOnqzj/YmL1V8QUbRHI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbfLKHHy (ORCPT ); Wed, 11 Dec 2019 02:07:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:38316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbfLKHHx (ORCPT ); Wed, 11 Dec 2019 02:07:53 -0500 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23CA520836; Wed, 11 Dec 2019 07:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576048073; bh=8msHcIRu3PefYDklXS+Yt8ZWDv8UpIyQUU1KePcXvUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I6qcpZab4oL1uW14v+yRpdRAmH74HJX44/xxYLcSVUaU32XzcNP4JLGJBnNmveSFV MmDkfr/0zyM16WKOx7IBoLVqAnppDSdic4/Gy8TTKhNPvwZhbdT5BHxUZD9xkBq1XH rW0BSLiJ6z5+LOmelSd8ur+Vfj/c7gjpBRnM+27U= Date: Wed, 11 Dec 2019 15:07:40 +0800 From: Shawn Guo To: Peng Fan Cc: "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa , "kernel@pengutronix.de" , dl-linux-imx , Aisheng Dong , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , "stable@vger.kernel.org" Subject: Re: [PATCH V2] clk: imx: pll14xx: fix clk_pll14xx_wait_lock Message-ID: <20191211070739.GL15858@dragon> References: <1575879445-15386-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575879445-15386-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 09, 2019 at 08:19:55AM +0000, Peng Fan wrote: > From: Peng Fan > > The usage of readl_poll_timeout is wrong, the 3rd parameter(cond) > should be "val & LOCK_STATUS" not "val & LOCK_TIMEOUT_US", > It is not check whether the pll locked, LOCK_STATUS reflects the mask, > not LOCK_TIMEOUT_US. > > Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc") > Cc: > Reviewed-by: Abel Vesa > Signed-off-by: Peng Fan Applied, thanks.