From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08385C43603 for ; Wed, 11 Dec 2019 07:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C093121556 for ; Wed, 11 Dec 2019 07:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HPfHwAfr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727827AbfLKHYg (ORCPT ); Wed, 11 Dec 2019 02:24:36 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:41110 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbfLKHYf (ORCPT ); Wed, 11 Dec 2019 02:24:35 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBB7EYeL106024; Wed, 11 Dec 2019 07:23:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=ly12157iHdm2LNcwiJ046REPVygJhzSMcv5KEc9fs6I=; b=HPfHwAfr+R7uuP/vB8zTTkruHNibcK33E7n66Ne26gqHl/ylG0Zm1+3CAzcFeFPUjG7J yqpxfgZjTnMxCbrn17WVXj5nICB1gGA9CpNH4431xJhdJBi/uiMAomDOyAeV8w78GWoX 9CkDCVkPxb9IQs7BKpJ6nn/Nm2UHg5vsMuNLH+8AJH4poPmfcsbJF5DFzHiPvxpAqh/O F2YmthVP3J7ReaP72wC/N8UAmPQ6Pn9pb9WCTy4t+Cpw4JbcLJkweOVPJPTPVU50V9Kr YOf45BbIHwj84G6Ai85gAvzC6ZYdgKIyZFgwRR+VEpjTnfQ+1X3foz3cz7OLFYRCEX6B Cg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2wr4qrjprh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 07:23:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBB7Etc6177177; Wed, 11 Dec 2019 07:23:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2wtqdu3y2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2019 07:23:07 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xBB7MjnW030170; Wed, 11 Dec 2019 07:22:49 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Dec 2019 23:22:45 -0800 Date: Wed, 11 Dec 2019 10:22:33 +0300 From: Dan Carpenter To: Aaro Koskinen Cc: Guenter Roeck , devel@driverdev.osuosl.org, Branden Bonaby , YueHaibing , Paul Burton , Julia Lawall , Greg Kroah-Hartman , Florian Westphal , linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Giovanni Gherdovich , Sandro Volery , Geert Uytterhoeven , Valery Ivanov , Petr =?utf-8?Q?=C5=A0tetiar?= , "David S. Miller" , Wambui Karuga Subject: Re: [PATCH 1/2] staging: octeon: delete driver Message-ID: <20191211072233.GB2070@kadam> References: <20191210091509.3546251-1-gregkh@linuxfoundation.org> <20191210120120.GA3779155@kroah.com> <20191210194659.GC18225@darkstar.musicnaut.iki.fi> <20191210201515.GA16912@roeck-us.net> <20191210214848.GA5834@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210214848.GA5834@darkstar.musicnaut.iki.fi> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110062 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9467 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912110062 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 11:48:49PM +0200, Aaro Koskinen wrote: > On Tue, Dec 10, 2019 at 12:15:15PM -0800, Guenter Roeck wrote: > > On Tue, Dec 10, 2019 at 09:46:59PM +0200, Aaro Koskinen wrote: > > > On Tue, Dec 10, 2019 at 01:01:20PM +0100, Greg Kroah-Hartman wrote: > > > > I have no idea :( > > > > > > It's stated in the TODO file you are deleting (visible in your > > > patch): "This driver is functional and supports Ethernet on > > > OCTEON+/OCTEON2/OCTEON3 chips at least up to CN7030." > > > > > > This includes e.g. some D-Link routers and Uniquiti EdgeRouters. You > > > can check from /proc/cpuinfo if you are running on this MIPS SoC. > > > > It also results in "mips:allmodconfig" build failures in mainline > > and is for that reason being marked as BROKEN. Unfortunately, > > misguided attempts to clean it up had the opposite effect. > > This was because of stubs hack added by someone - people who do not run > or care about the hardware can now break it for others with their > silly x86 "compile test"s. Compile tests are nice in theory for finding static analysis bugs but often they introduce static checker false positives because we don't initialize *param variables in the stub functions. And those compat stubs in particular were a headache to review. We broke the build a couple times, but we *almost* broke the build a *lot* of times... regards, dan carpenter