public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	cl@linux.com, mgalbraith@suse.de, mhocko@suse.com,
	torvalds@linux-foundation.org, umgwanakikbuti@gmail.com,
	wagi@monom.org, stable-commits@vger.kernel.org,
	"Wangkefeng (Maro)" <wangkefeng.wang@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>
Subject: Re: Patch "mm, vmstat: make quiet_vmstat lighter" has been added to the 4.4-stable tree
Date: Wed, 11 Dec 2019 15:46:14 +0100	[thread overview]
Message-ID: <20191211144614.GA637714@kroah.com> (raw)
In-Reply-To: <e4bd396a-1a10-1387-aa3f-4d61d31ab7b6@huawei.com>

On Wed, Dec 11, 2019 at 10:32:49PM +0800, zhangyi (F) wrote:
> Hi, all
> 
> We find a performance degradation under lmbench af_unix[1] test case after
> mergeing this patch on my x86 qemu 4.4 machine. The test result is basically
> stable for each teses.
> 
> Host machine: CPU: Intel(R) Xeon(R) CPU E5-2690 v3
>               CPU(s): 48
>               MEM: 193047 MB
> 
> Guest machine:  CPU: QEMU Virtual CPU version 2.5+
>                 CPU(s): 8
>                 MEM: 26065 MB
> 
>   Before this patch:
>   [root@localhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 133.7073 microseconds
> 
>   After this patch:
>   [root@localhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 156.4722 microseconds
> 
> If we set task to a constant cpu, the degradation does not appear.
> 
>   Before this patch:
>   [root@localhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 17.9296 microseconds
> 
>   After this patch:
>   [root@localhost ~]# lmbench-3.0-a9/bin/x86_64-linux-gnu/lat_unix -P 1
>   AF_UNIX sock stream latency: 17.7500 microseconds
> 
> We also test it on the aarch64 hi1215 machine with 8 cpu cores.
> 
>   Before this patch:
>   [root@localhost ~]# ./lat_unix -P 1
>   AF_UNIX sock stream latency: 30.7 microseconds
> 
>   After this patch:
>   [root@localhost ~]# ./lat_unix -P 1
>   AF_UNIX sock stream latency: 37.5 microseconds
> 
> Accessories included my reproduce config for x86 qemu. Any thoughts?

This fixes a bug, as reported by Daniel Wagner.  So it's probably better
to have a stable system instead of a broken one, right?  :)

Daniel can provide more information if needed.

What about when you run your tests on a 4.9 or newer kernel that already
has this integrated?

thanks,

greg k-h

  parent reply	other threads:[~2019-12-11 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <156442332854185@kroah.com>
2019-12-11 14:32 ` Patch "mm, vmstat: make quiet_vmstat lighter" has been added to the 4.4-stable tree zhangyi (F)
2019-12-11 14:40   ` Michal Hocko
2019-12-11 14:46   ` Greg KH [this message]
2019-12-11 15:54     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211144614.GA637714@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mhocko@suse.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=umgwanakikbuti@gmail.com \
    --cc=wagi@monom.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=xiexiuqi@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox