Re: [PATCH 4.19 134/243] bpf: btf: check name validity for various types

Pavel Machek
2019-12-12T12:06:28Z

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Wed 2019-12-11 16:04:56, Greg Kroah-Hartman wrote:
> From: Yonghong Song <yhs@fb.com>
>
> [ Upstream commit eb04bbb608e683f8fd3ef7f716e2fa32dd90861f ]
>
> This patch added name checking for the following types:
> . BTF_KIND_PTR, BTF_KIND_ARRAY, BTF_KIND_VOLATILE,
> BTF_KIND_CONST, BTF_KIND_RESTRICT:
> the name must be null
> . BTF_KIND_STRUCT, BTF_KIND_UNION: the struct/member name
> is either null or a valid identifier
> . BTF_KIND_ENUM: the enum type name is either null or a valid
> identifier; the enumerator name must be a valid identifier.
> . BTF_KIND_FWD: the name must be a valid identifier
> . BTF_KIND_TYPEDEF: the name must be a valid identifier
>
> For those places a valid name is required, the name must be
> a valid C identifier. This can be relaxed later if we found
> use cases for a different (non-C) frontend.

Does this fix any serious bug? I don't think this is suitable for
stable.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]