Re: [PATCH AUTOSEL 5.4 032/134] leds: lm3692x: Handle failure to probe the regulator

Pavel Machek
2019-12-14T08:42:34Z

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Wed 2019-12-11 10:10:08, Sasha Levin wrote:
> From: Guido Günther <agx@sigxcpu.org>
>
> [ Upstream commit 396128d2ffcba6e1954cfdc9a89293ff79cbfd7c ]
>
> Instead use devm_regulator_get_optional since the regulator
> is optional and check for errors.

Support for new hardware, more than serious bug.

Please drop. Also please drop leds from your monitoring scripts, it
just adds unneccessary workload for everyone. If we see something
_really_ critical, we'll cc: stable.

Actually, I believe your monitoring scripts are doing more harm than
good, and it would be better to get positive confirmation from
contributors before pushing random changes into stable.

Thanks,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]