From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896E7C43603 for ; Wed, 11 Dec 2019 15:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 572F7208C3 for ; Wed, 11 Dec 2019 15:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078036; bh=eEYsWr+eFCuXJVM3sKPLmXj1gpsJq1LjKsaQ+vTQuyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vBKpvAjkDqGPzTA7csRWpIdffiyulugyPZGWXxWXG91kuuqrgTOwED2lQlybt7F3k 2yjHCWMUO4LNEplEwqV6oUaPuiG5L75pZmiBLW66gPQHg24PviYaZ6F/kPMGUiy3AS eY2DVFXyqaey/WhXbFeZfQKL9aSVx4qkFa7b4ywY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733278AbfLKP1P (ORCPT ); Wed, 11 Dec 2019 10:27:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:60734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732720AbfLKP1F (ORCPT ); Wed, 11 Dec 2019 10:27:05 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 069A324680; Wed, 11 Dec 2019 15:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078024; bh=eEYsWr+eFCuXJVM3sKPLmXj1gpsJq1LjKsaQ+vTQuyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dTEbRJn4SdRDpm/QvEvdjaz7khVoeTC+RJNWn4ZNEKusriarrdmwqItKcgkebOa9/ mtATXeWLbkD1LqEAM7ytt0+l0NXeDEcTJ4i8buyJE39xH1ugVDbttRou0z8D8nngvw DMFJd+lstMkX2sh+RRd7lVwajDHybD3DEhcCYEMA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chuhong Yuan , Daniel Lezcano , Sasha Levin Subject: [PATCH AUTOSEL 4.19 19/79] clocksource/drivers/asm9260: Add a check for of_clk_get Date: Wed, 11 Dec 2019 10:25:43 -0500 Message-Id: <20191211152643.23056-19-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211152643.23056-1-sashal@kernel.org> References: <20191211152643.23056-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit 6e001f6a4cc73cd06fc7b8c633bc4906c33dd8ad ] asm9260_timer_init misses a check for of_clk_get. Add a check for it and print errors like other clocksource drivers. Signed-off-by: Chuhong Yuan Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20191016124330.22211-1-hslester96@gmail.com Signed-off-by: Sasha Levin --- drivers/clocksource/asm9260_timer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/clocksource/asm9260_timer.c b/drivers/clocksource/asm9260_timer.c index 38cd2feb87c42..0ce760776406b 100644 --- a/drivers/clocksource/asm9260_timer.c +++ b/drivers/clocksource/asm9260_timer.c @@ -198,6 +198,10 @@ static int __init asm9260_timer_init(struct device_node *np) } clk = of_clk_get(np, 0); + if (IS_ERR(clk)) { + pr_err("Failed to get clk!\n"); + return PTR_ERR(clk); + } ret = clk_prepare_enable(clk); if (ret) { -- 2.20.1