From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9293C43603 for ; Wed, 11 Dec 2019 15:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B636D22B48 for ; Wed, 11 Dec 2019 15:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078555; bh=VKrwJsQCUBo9OLMWbHAIE4Wb9a2Fdb3qcuc2ODxMWcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tkNozS8H5xYwKxkNFikR1gGOePsi1kJ/kF+cEOlA21+lAOEAhH9QMaG90uWFoHtIh ucdxw+rIp9P+3x9LGvJyoLP9MT/FVjH66rAPuoVyhF2azw03j+1qX30Ks306JHiUBh QixIGAdJkRN8KSFCns80hWvCReVKnWcspTWpXT48= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388254AbfLKPfz (ORCPT ); Wed, 11 Dec 2019 10:35:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:44982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388218AbfLKPfq (ORCPT ); Wed, 11 Dec 2019 10:35:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 213432077B; Wed, 11 Dec 2019 15:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576078545; bh=VKrwJsQCUBo9OLMWbHAIE4Wb9a2Fdb3qcuc2ODxMWcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OxB5b9QVh/f8ONYfUqCJ7r4SSfqYga4irGv2pY/M3JGl6Jl5kCg8KHnygfBzZO4ex HNvbQfoBSshz5qKFarQVHTImp6MqzrjRCaDo88C9zYn1NC/Rwep/NXlWuvr7v/ngEp pmOZEPrvT808+W2VAJc1064dkjwldHXP2NzKVUJM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maurizio Lombardi , Douglas Gilbert , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 33/42] scsi: scsi_debug: num_tgts must be >= 0 Date: Wed, 11 Dec 2019 10:35:01 -0500 Message-Id: <20191211153510.23861-33-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211153510.23861-1-sashal@kernel.org> References: <20191211153510.23861-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maurizio Lombardi [ Upstream commit aa5334c4f3014940f11bf876e919c956abef4089 ] Passing the parameter "num_tgts=-1" will start an infinite loop that exhausts the system memory Link: https://lore.kernel.org/r/20191115163727.24626-1-mlombard@redhat.com Signed-off-by: Maurizio Lombardi Acked-by: Douglas Gilbert Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_debug.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 2b0e61557317f..d7118d3767c35 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -4953,6 +4953,11 @@ static int __init scsi_debug_init(void) return -EINVAL; } + if (sdebug_num_tgts < 0) { + pr_err("num_tgts must be >= 0\n"); + return -EINVAL; + } + if (sdebug_guard > 1) { pr_err("guard must be 0 or 1\n"); return -EINVAL; -- 2.20.1