public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, vkuznets@redhat.com,
	wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [PATCH 0/6] Fix various comment errors
Date: Wed, 11 Dec 2019 08:01:40 -0800	[thread overview]
Message-ID: <20191211160140.GC5044@linux.intel.com> (raw)
In-Reply-To: <1576045585-8536-1-git-send-email-linmiaohe@huawei.com>

On Wed, Dec 11, 2019 at 02:26:19PM +0800, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
> 
> Fix various comment mistakes, such as typo, grammar mistake, out-dated
> function name, writing error and so on. It is a bit tedious and many
> thanks for review in advance.
> 
> Miaohe Lin (6):
>   KVM: Fix some wrong function names in comment
>   KVM: Fix some out-dated function names in comment
>   KVM: Fix some comment typos and missing parentheses
>   KVM: Fix some grammar mistakes
>   KVM: hyperv: Fix some typos in vcpu unimpl info
>   KVM: Fix some writing mistakes

Regarding the patch organizing, I'd probably group the comment changes
based on what files they touch as opposed to what type of comment issue
they're fixing.

E.g. three patches for the comments

   KVM: VMX: Fix comment blah blah blah
   KVM: x86: Fix comment blah blah blah
   KVM: Fix comment blah blah blah

and one patch for the print typo in hyperv

   KVM: hyperv: Fix some typos in vcpu unimpl info

For KVM, the splits don't matter _that_ much since they more or less all
get routed through the maintainers/reviewers, but it is nice when patches
can be contained to specific subsystems/areas as it allows people to easily
skip over patches that aren't relevant to them.

>  arch/x86/include/asm/kvm_host.h       | 2 +-
>  arch/x86/kvm/hyperv.c                 | 6 +++---
>  arch/x86/kvm/ioapic.c                 | 2 +-
>  arch/x86/kvm/lapic.c                  | 4 ++--
>  arch/x86/kvm/vmx/nested.c             | 2 +-
>  arch/x86/kvm/vmx/vmcs_shadow_fields.h | 4 ++--
>  arch/x86/kvm/vmx/vmx.c                | 8 ++++----
>  virt/kvm/kvm_main.c                   | 6 +++---
>  8 files changed, 17 insertions(+), 17 deletions(-)
> 
> -- 
> 2.19.1
> 

  parent reply	other threads:[~2019-12-11 16:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  6:26 [PATCH 0/6] Fix various comment errors linmiaohe
2019-12-11  6:26 ` [PATCH 1/6] KVM: Fix some wrong function names in comment linmiaohe
2019-12-11  6:26 ` [PATCH 2/6] KVM: Fix some out-dated " linmiaohe
2019-12-11  6:26 ` [PATCH 3/6] KVM: Fix some comment typos and missing parentheses linmiaohe
2019-12-11 15:46   ` Sean Christopherson
2019-12-11  6:26 ` [PATCH 4/6] KVM: Fix some grammar mistakes linmiaohe
2019-12-11  6:26 ` [PATCH 5/6] KVM: hyperv: Fix some typos in vcpu unimpl info linmiaohe
2019-12-11  6:26 ` [PATCH 6/6] KVM: Fix some writing mistakes linmiaohe
2019-12-11 15:51   ` Sean Christopherson
2019-12-11 16:01 ` Sean Christopherson [this message]
2020-01-15 17:56 ` [PATCH 0/6] Fix various comment errors Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2019-12-12  2:08 linmiaohe
2019-12-12  2:59 ` Xiaoyao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211160140.GC5044@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox