From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0E2C2D0C7 for ; Wed, 11 Dec 2019 16:23:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A04E2077B for ; Wed, 11 Dec 2019 16:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730682AbfLKQXs (ORCPT ); Wed, 11 Dec 2019 11:23:48 -0500 Received: from mga03.intel.com ([134.134.136.65]:42369 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729522AbfLKQXr (ORCPT ); Wed, 11 Dec 2019 11:23:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 08:23:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="220492114" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 11 Dec 2019 08:23:42 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 11 Dec 2019 18:23:41 +0200 Date: Wed, 11 Dec 2019 18:23:41 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Colin King Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drm/i915/display: remove duplicated assignment to pointer crtc_state Message-ID: <20191211162341.GM1208@intel.com> References: <20191210144535.341977-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191210144535.341977-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 02:45:35PM +0000, Colin King wrote: > From: Colin Ian King > > Pointer crtc_state is being assigned twice, one of these is redundant > and can be removed. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 5c50b7d2db25..f3389d315b19 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev, > > for_each_intel_crtc(&dev_priv->drm, crtc) { > struct intel_crtc_state *crtc_state = > - crtc_state = to_intel_crtc_state(crtc->base.state); > + to_intel_crtc_state(crtc->base.state); Thanks. Pushed to drm-intel-next-queued. > > intel_sanitize_crtc(crtc, ctx); > intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]"); > -- > 2.24.0 -- Ville Syrjälä Intel