Re: ftrace histogram sorting broken on BE architecures

Tom Zanussi
2019-12-11T19:26:07Z

Hi Steve,

On Wed, 2019-12-11 at 12:00 -0500, Steven Rostedt wrote:
> On Wed, 11 Dec 2019 10:37:18 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > > Tom,
> > >
> > > Correct me if I'm wrong, from what I can tell, all sums and keys
> > > are
> > > u64 unless they are a string. Thus, I believe this patch should
> > > not
> > > have any issues.
> >
> > The sums are u64, but the keys may not be. I'll take a look and
> > see,
>
> Are they? I see in create_key_field:
>
> key_size = ALIGN(key_size, sizeof(u64));
>
> Which to me seems that we'll have nothing smaller than sizeof(u64).
>

Yeah, that makes them effectively u64 in this case, so I'd agree.

Tom