Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements

Lakshmi Ramasubramanian
2019-12-12T16:57:21Z

On 12/12/19 12:19 AM, Mimi Zohar wrote:

>>> + ima_process_keys = true;
>> +
>> + INIT_LIST_HEAD(&temp_ima_keys);
>> +
>> + mutex_lock(&ima_keys_mutex);
>> +
>> + list_for_each_entry_safe(entry, tmp, &ima_keys, list)
>> + list_move_tail(&entry->list, &temp_ima_keys);
>> +
>> + mutex_unlock(&ima_keys_mutex);
>
>
> The v1 comment, which explained the need for using a temporary
> keyring, is an example of an informative comment.  If you don't
> object, instead of re-posting this patch, I can insert it.
>
> Mimi

Sure Mimi. Thanks for including the comment in the patch.

thanks,
-lakshmi