Re: [PATCH v3 2/7] usb: musb: dma: Add support for shared IRQ

Bin Liu
2019-12-17T21:18:39Z

On Tue, Dec 17, 2019 at 10:04:38PM +0100, Paul Cercueil wrote:
> Hi Bin,
>
>
> Le mar., déc. 17, 2019 at 08:42, Bin Liu <b-liu@ti.com> a écrit :
> > Hi Paul,
> >
> > On Wed, Dec 11, 2019 at 12:52:24PM -0600, Bin Liu wrote:
> > > On Tue, Dec 10, 2019 at 06:11:05PM +0100, Paul Cercueil wrote:
> > > > The implementation of the Inventra IP in some of the Ingenic
> > > JZ47xx SoCs
> > > > does not use a separate IRQ line for DMA transfers.
> > > >
> > > > Allow these SoCs to be supported by adding a flag
> > > 'dma_share_usb_irq'
> > > > in the struct musb. If set, no extra IRQ line is required, and
> > > the musb
> > > > glue will need to call the API function
> > > musbhs_dma_controller_irq()
> > > > within its interrupt handler.
> > > >
> > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > > > Tested-by: Artur Rojek <contact@artur-rojek.eu>
> > > > ---
> > >
> > > Queued for usb-next. Thanks.
> >
> > I removed this and the next patch [3/7] in this series from my queue.
> > Sorry. Ming Guo has posted a series "Add MediaTek MUSB Controller
> > Driver" which has done the similar implementation [1] but without adding
> > the flag in struct musb. Can you please check if you can use Ming's
> > implementation instead? The patch of his musb glue driver which uses the
> > implementation is [2], just for your reference.
>
> Sure. Were these patches merged? What tree do they apply to? They don't
> apply cleanly on -rc2.

I am currently doing the last round review and test on those patches,
applying them to Greg's -next branch. Yes, they don't apply cleanly on
-rc2, but manual apply doesn't have any issue.

-Bin.