From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7A4C00454 for ; Wed, 11 Dec 2019 19:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B74F020836 for ; Wed, 11 Dec 2019 19:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728128AbfLKTCi (ORCPT ); Wed, 11 Dec 2019 14:02:38 -0500 Received: from verein.lst.de ([213.95.11.211]:56918 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727133AbfLKTCi (ORCPT ); Wed, 11 Dec 2019 14:02:38 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id BD11668AFE; Wed, 11 Dec 2019 20:02:35 +0100 (CET) Date: Wed, 11 Dec 2019 20:02:35 +0100 From: Christoph Hellwig To: Robin Murphy Cc: joro@8bytes.org, hch@lst.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stephan@gerhold.net, natechancellor@gmail.com, nsaenzjulienne@suse.de, arnd@arndb.de Subject: Re: [PATCH v2] iommu/dma: Rationalise types for DMA masks Message-ID: <20191211190235.GA17854@lst.de> References: <00d1ddf9439a8c79fb561b0fc740bddf9e6fe6b1.1576089015.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00d1ddf9439a8c79fb561b0fc740bddf9e6fe6b1.1576089015.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 06:33:26PM +0000, Robin Murphy wrote: > Since iommu_dma_alloc_iova() combines incoming masks with the u64 bus > limit, it makes more sense to pass them around in their native u64 > rather than converting to dma_addr_t early. Do that, and resolve the > remaining type discrepancy against the domain geometry with a cheeky > cast to keep things simple. > > Signed-off-by: Robin Murphy Looks good to me: Reviewed-by: Christoph Hellwig Joerg, let me know if you want to pick this up through the iommu tree as it touches the iommu code, or through the dma-mapping tree that introduced the warning.