Re: [PATCH] of: refcount leak when phandle_cache entry replaced

Rob Herring
2019-12-11T20:18:59Z

On Tue, 10 Dec 2019 02:14:53 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> of_find_node_by_phandle() does not do an of_node_put() of the existing
> node in a phandle cache entry when that node is replaced by a new node.
>
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Fixes: b8a9ac1a5b99 ("of: of_node_get()/of_node_put() nodes held in phandle cache")
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>
> Checkpatch will warn about a line over 80 characters. Let me know
> if that bothers you.
>
> drivers/of/base.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Applied, thanks.

Rob