From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EAEC2D0C6 for ; Thu, 12 Dec 2019 00:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8903C20637 for ; Thu, 12 Dec 2019 00:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbfLLAw6 (ORCPT ); Wed, 11 Dec 2019 19:52:58 -0500 Received: from foss.arm.com ([217.140.110.172]:54270 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727235AbfLLAw6 (ORCPT ); Wed, 11 Dec 2019 19:52:58 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8AAB431B; Wed, 11 Dec 2019 16:52:57 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D035B3F52E; Wed, 11 Dec 2019 16:52:56 -0800 (PST) Date: Thu, 12 Dec 2019 00:52:55 +0000 From: Andrew Murray To: Robin Murphy Cc: Vicente Bergas , Bjorn Helgaas , Shawn Lin , Heiko Stuebner , Liam Girdwood , Mark Brown , Heiner Kallweit , "Rafael J. Wysocki" , Lorenzo Pieralisi , Frederick Lawler , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Philipp Zabel , Andy Shevchenko , Mika Westerberg , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-arm-kernel@lists.infradead.org Subject: Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin Message-ID: <20191212005254.GE24359@e119886-lin.cambridge.arm.com> References: <58ce5534-64bd-4b4b-bd60-ed4e0c71b20f@gmail.com> <166f0016-7061-be5c-660d-0499f74e8697@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <166f0016-7061-be5c-660d-0499f74e8697@arm.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: > Hi Vicente, > > On 2019-12-11 11:38 pm, Vicente Bergas wrote: > > Hi, > > since v5.5-rc1 the google kevin chromebook does not boot. > > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() > > unnecessary locking > > as the first bad commit. > > > > In order to revert it from v5.5-rc1 i had to also revert some dependencies: > > 5e0c21c75e8c08375a69710527e4a921b897cb7e > > aff5d0552da4055da3faa27ee4252e48bb1f5821 > > 35efea32b26f9aacc99bf07e0d2cdfba2028b099 > > 687aaf386aeb551130f31705ce40d1341047a936 > > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d > > 87e90283c94c76ee11d379ab5a0973382bbd0baf > > After reverting all of this, still no luck. > > So, either the results of git bisect are not to be trusted, or > > there are more bad commits. > > > > By "does not boot" i mean that the display fails to start and > > the display is the only output device, so debugging is quite difficult. > > Assuming it's a manifestation of the same PCI breakage that Enric and > Lorenzo figured out, there's a proposed fix here: > https://lkml.org/lkml/2019/12/11/199 It's likely that any PCI driver that uses PCI IO with that controller will suffer the same fate. Vicente - can you try the patch that has been proposed and verify it fixes the issue for you? Thanks, Andrew Murray > > Robin. > > > v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI: > > # CONFIG_PCI is not set > > > > Regards, > >  Vicente. > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip