From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
AlekseyMakarov <aleksey.makarov@linaro.org>
Subject: Re: [RFC/PATCH] printk: Fix preferred console selection with multiple matches
Date: Thu, 12 Dec 2019 10:23:19 +0900 [thread overview]
Message-ID: <20191212012319.GP88619@google.com> (raw)
In-Reply-To: <20191211091740.p6bgjy7sy75maenw@pathway.suse.cz>
On (19/12/11 10:17), Petr Mladek wrote:
> And this would exactly happen as pointed out by Sergey. match() does
> also some setup operations. I would be scared to call them twice.
>
> > This looks indeed a lot more invasive. Is there any reason why what I
> > propose wouldn't work as a first patch that can easily be backported ?
>
> Your solution is not acceptable because it might cause calling
> match() more times.
>
> The reverse search of list of console does not work for ttySX
> consoles because the number is omitted when matching. And the messages
> will appear only on the first matched serial console. There is
> a paragraph about this in the commit message of my patch.
A fast path for preferred_console match()/setup() sounds like
something that may work. There won't be double setup()-s and
we scan console list in the same direction. We just have
separate match()/setup() for preferred_console. Do you think
this won't do the trick?
-ss
next prev parent reply other threads:[~2019-12-12 1:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 0:57 [RFC/PATCH] printk: Fix preferred console selection with multiple matches Benjamin Herrenschmidt
2019-12-10 8:01 ` Sergey Senozhatsky
2019-12-10 22:26 ` Benjamin Herrenschmidt
2019-12-11 2:01 ` Sergey Senozhatsky
2019-12-11 4:02 ` Benjamin Herrenschmidt
2019-12-11 5:35 ` Sergey Senozhatsky
2019-12-11 12:53 ` Petr Mladek
2019-12-10 9:15 ` Petr Mladek
2019-12-10 22:39 ` Benjamin Herrenschmidt
2019-12-11 9:17 ` Petr Mladek
2019-12-12 1:23 ` Sergey Senozhatsky [this message]
2019-12-16 0:09 ` Benjamin Herrenschmidt
2019-12-19 9:50 ` Petr Mladek
2019-12-12 0:35 ` Benjamin Herrenschmidt
2019-12-12 9:09 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212012319.GP88619@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=aleksey.makarov@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox