From: Hans de Goede <hdegoede@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 5.5 regression fix 0/2] efi/libstub: Fix mixed-mode crash at boot
Date: Thu, 12 Dec 2019 11:31:56 +0100 [thread overview]
Message-ID: <20191212103158.4958-1-hdegoede@redhat.com> (raw)
Hi All,
Commit 0d95981438c3 ("x86: efi/random: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table")
causes drivers/efi/libstub/random.c to be used on x86 for the first time
and some of the code in that file does not deal properly with mixed-mode
setups causing a crash at boot on mixed-mode devices.
The first patch in this series fixes this and is the regression-fix from
$subject.
While looking into this I did a quick search for other cases of the same
problem in the libstub code and I found the same issue in the handling of
LILO-style file= kernel commandline arguments, which I guess are not
used that often because AFAICT we have no bug report for these not working
in mixed-mode. The second patch fixes this, this is a pre-existing problem
and not a 5.5 regression, still we should probably also include this fix
in 5.5.
Regards,
Hans
next reply other threads:[~2019-12-12 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 10:31 Hans de Goede [this message]
2019-12-12 10:31 ` [PATCH 5.5 regression fix 1/2] efi/libstub/random: Initialize pointer variables to zero for mixed mode Hans de Goede
2019-12-12 10:37 ` Ard Biesheuvel
2019-12-12 10:31 ` [PATCH 5.5 regression fix 2/2] efi/libstub/helper: " Hans de Goede
2019-12-12 11:29 ` Ard Biesheuvel
2019-12-12 12:38 ` Hans de Goede
2019-12-12 12:45 ` Hans de Goede
2019-12-12 14:02 ` Ard Biesheuvel
2019-12-13 8:46 ` Ard Biesheuvel
2019-12-12 12:29 ` [PATCH 5.5 regression fix 0/2] efi/libstub: Fix mixed-mode crash at boot Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212103158.4958-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox