From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5B6C43603 for ; Thu, 12 Dec 2019 13:14:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B3621655 for ; Thu, 12 Dec 2019 13:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729383AbfLLNOc (ORCPT ); Thu, 12 Dec 2019 08:14:32 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:47726 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729170AbfLLNOc (ORCPT ); Thu, 12 Dec 2019 08:14:32 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifOIT-0004ep-6P; Thu, 12 Dec 2019 13:14:25 +0000 Date: Thu, 12 Dec 2019 13:14:25 +0000 From: Al Viro To: Hillf Danton Cc: syzbot , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: BUG: corrupted list in __dentry_kill (2) Message-ID: <20191212131425.GF4203@ZenIV.linux.org.uk> References: <20191212104355.24672-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191212104355.24672-1-hdanton@sina.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 06:43:55PM +0800, Hillf Danton wrote: > Unpin dentry no more than once as it's pinned only once. The first time is on the entry into simple_recursive_removal(), by + struct dentry *this = dget(dentry);