From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A58C43603 for ; Thu, 12 Dec 2019 18:24:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0C8922527 for ; Thu, 12 Dec 2019 18:24:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="otNCU/9i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730429AbfLLSYR (ORCPT ); Thu, 12 Dec 2019 13:24:17 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:45231 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730295AbfLLSYQ (ORCPT ); Thu, 12 Dec 2019 13:24:16 -0500 Received: by mail-pj1-f67.google.com with SMTP id r11so1363750pjp.12 for ; Thu, 12 Dec 2019 10:24:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u1PHlHUdNRkLYDULqBTcDHsCK0nWR/67FBcfs8Oqumk=; b=otNCU/9in36hydlyZDESi7f5IA1iX06dCDae98JkQRLbariMr32467Lz6Qu0ScMrmh +u6NLSvFW3ESXgW94Yoqt9owpUcY+nONAyJSPGSHhakpPDvio0g9a1J89i3+UoSj4HY4 JL+7ItCOIIw5A+C9qVwZotVcuXjeEt9cUAKQLegYiFfJB0az+qKIlOSXU0tkfyMShsxp G/ecVTMPFi3ptkxnOrcvywkbzwHyOqNs8xuwhLwbvLmpc68uLPD91znn31R8REPW5kV7 U0tThNOx/pLhrE4E8ZdgMfNa0zbbdrMO8C1uPopM7FwK4cx5LpDUIHIS9WY8X0AXvgnb C3Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u1PHlHUdNRkLYDULqBTcDHsCK0nWR/67FBcfs8Oqumk=; b=GkCsjNeUsbl2P4OduFMHtEeHiEcZNRh7YMpbbwhtJx2fExfKWuJRRBjsYmFTO+aUjq 7aNIv22EDPMrpPpJSuVFeiS7RWgyp9VX5Zieot5SgpxWfGvJUMw+hdD83P0E6JviHDmt +3BUS1dEcHisLm5ZtbLDCsmet6TY2PvLvteAS108Udq8v/EuvWTPf41RdlQOB/AISOsD hJbaE9aMAcT6VvW/Bkdh0izTE/FdHcEYp6EyicHuV8F3iv7gQcr/56IlbNMkO88q3ptE XRp/wKEFKGP04VNG3SRCBCp+qMp1Ijy8a3CvcWQZgPhVy0/1VQ8lFIL/3uUiV9lTms7A Yg7w== X-Gm-Message-State: APjAAAWNe8aiy3nWgPIlbPwOAmj3xmXBvmGFXC5fV30wX1XTZOQ6Jmuk TwEWH3UVHDHZb8vzOTQDS5nycg== X-Google-Smtp-Source: APXvYqysKkIuW1bkdC2A856WgquKQLYeFECzV0m5sJBtr9RxOmKEcCR0YAEPhVdRk8gZU0lveLD8Dw== X-Received: by 2002:a17:902:8603:: with SMTP id f3mr10631884plo.198.1576175055155; Thu, 12 Dec 2019 10:24:15 -0800 (PST) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id d27sm7757087pgm.53.2019.12.12.10.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2019 10:24:14 -0800 (PST) Date: Thu, 12 Dec 2019 10:24:11 -0800 From: Bjorn Andersson To: cang@codeaurora.org Cc: Avri Altman , asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Evan Green , Kishon Vijay Abraham I , Stephen Boyd , Stanley Chu , Vignesh Raghavendra , Bean Huo , Bart Van Assche , Venkat Gopalakrishnan , Tomas Winkler , Arnd Bergmann , open list Subject: Re: [PATCH v2 2/3] scsi: ufs: Modulize ufs-bsg Message-ID: <20191212182411.GE415177@yoga> References: <1576054123-16417-1-git-send-email-cang@codeaurora.org> <0101016ef425ef65-5c4508cc-5e76-4107-bb27-270f66acaa9a-000000@us-west-2.amazonses.com> <20191212045357.GA415177@yoga> <0101016ef8b2e2f8-72260b08-e6ad-42fc-bd4b-4a0a72c5c9b3-000000@us-west-2.amazonses.com> <20191212063703.GC415177@yoga> <0101016efb07efac-32cf270a-68dd-455a-b037-9fac2f3834cd-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0101016efb07efac-32cf270a-68dd-455a-b037-9fac2f3834cd-000000@us-west-2.amazonses.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 12 Dec 08:53 PST 2019, cang@codeaurora.org wrote: > On 2019-12-12 15:00, Avri Altman wrote: > > > On Wed 11 Dec 22:01 PST 2019, cang@codeaurora.org wrote: > > > > On 2019-12-12 12:53, Bjorn Andersson wrote: > > > > > On Wed 11 Dec 00:49 PST 2019, Can Guo wrote: [..] > > > > And in real cases, as the UFS is the boot device, UFS driver will always > > > > be probed during bootup. > > > > > > > > > > The UFS driver will load and probe because it's mentioned in the > > > devicetree, but if either the ufs drivers or any of its dependencies > > > (phy, resets, clocks, etc) are built as modules it might very well > > > finish probing after lateinitcall. > > > > > > So in the even that the bsg is =y and any of these drivers are =m, > > > or if > > > you're having bad luck with your timing, the list will be empty. > > > > > > As described below, if bsg=m, then there's nothing that will load the > > > module and the bsg will not probe... > > Right. > > bsg=y and ufshcd=m is a bad idea, and should be avoided. > > > > Yeah, I will get it addressed in the next patchset. > If you build this around platform_device_register_data() from ufshcd I don't see a reason to add additional restrictions on this combination (even though it might not make much sense for people to use this combination). Regards, Bjorn