From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] use do_mount() instead of ksys_mount()
Date: Thu, 12 Dec 2019 18:37:13 +0000 [thread overview]
Message-ID: <20191212183713.GI4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wgQRXLjXC5YxJd1VHoGpMB6wg=2XaLj1FgH=H+bP8=fDQ@mail.gmail.com>
On Thu, Dec 12, 2019 at 09:11:10AM -0800, Linus Torvalds wrote:
> On Thu, Dec 12, 2019 at 5:59 AM Dominik Brodowski
> <linux@dominikbrodowski.net> wrote:
> >
> > This small series replaces all in-kernel calls to the
> > userspace-focused wrapper ksys_mount() with calls to
> > the kernel-centric do_mount().
>
> If you fix the pointless cast I pointed out, and put it in a git
> branch, I'll pull it.
>
> In fact, just do both series in the same branch, they do conceptually
> the same thing, after all.
IMO it's not a good idea. Exposing the guts of fs/namespace.c to
what's essentially a userland code that happens to run in kernel thread
is asking for trouble - we'd been there and it had been hell to untangle.
prev parent reply other threads:[~2019-12-12 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 13:57 [PATCH 0/3] use do_mount() instead of ksys_mount() Dominik Brodowski
2019-12-12 13:57 ` [PATCH 1/3] devtmpfs: " Dominik Brodowski
2019-12-12 13:57 ` [PATCH 2/3] initrd: " Dominik Brodowski
2019-12-12 13:57 ` [PATCH 3/3] init: " Dominik Brodowski
2019-12-16 1:35 ` Ondřej Jirman
2019-12-16 1:36 ` Ondřej Jirman
2019-12-16 3:50 ` Linus Torvalds
2019-12-16 5:13 ` Eric Biggers
2019-12-16 13:21 ` Geert Uytterhoeven
2019-12-16 15:04 ` Guenter Roeck
2019-12-16 15:53 ` Guido Günther
2019-12-16 21:12 ` Nick Desaulniers
2019-12-17 6:38 ` Dominik Brodowski
2019-12-17 18:04 ` Nick Desaulniers
2019-12-12 17:11 ` [PATCH 0/3] " Linus Torvalds
2019-12-12 18:37 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212183713.GI4203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox