From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E052C00454 for ; Thu, 12 Dec 2019 23:46:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01E752253D for ; Thu, 12 Dec 2019 23:46:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X8NY5D0i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731379AbfLLXqV (ORCPT ); Thu, 12 Dec 2019 18:46:21 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34703 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfLLXqU (ORCPT ); Thu, 12 Dec 2019 18:46:20 -0500 Received: by mail-pf1-f195.google.com with SMTP id l127so344160pfl.1 for ; Thu, 12 Dec 2019 15:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eIHQNr9eba5L4XlIbOyWJRxI2gHfserq4iuA29IFaDM=; b=X8NY5D0iToa7JChnlhDAEszCIxTzy3LeWj/cfBf7BkV8CYiBtUDe0n81/4Gs32p8ai wl+gKwVYoOCPR/C1Q0o8ibrQett7r8j3amhvEjrlim8MYysj3YsObaDwTuD1EQeddqbc qfro0Tk+k3ZN4+MYsTiR5ECdbZGpWUBMB7A4VCGFV/Ku8wvYMmZGCmzWqxZ3z+ysaOc/ ij/ms0WrKYveYecgTzJE4830I3L1LUDmFY5Dxq37WZ+KepfZW3h5LzWTp1iu8PiZ4W9a UuKaTJjjdUAFfirNmhXU7vnFVev0Jh9gYV4t2bRrHaLCTdKFfwXA6EXf63Sw4nbgSN9Q ejrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eIHQNr9eba5L4XlIbOyWJRxI2gHfserq4iuA29IFaDM=; b=ucnxWLr8d7nnsytW6ZBq/kAGcmyfEhSwWIHbUAhAt0UUE8t9RvZVugm2RdBuTV53Gk kgiZAyTXPgfqt5Zal0dsEA6Q5smk0kLMzCa+Bxbnz/vPJ/Z9WzjZlEdEBX3fzXERrUkq 2jdaWBf5ZJ1kMb4xl8r18bZWXwZcfOolPfocT8STnCWPU9mWfKRA1XKjdA8z5cOzCQ1l TJYinU5eLT6iQTj/Eg/nTzmcl8fLwXcsPG32wozY7wHC7AnP5a8JPpjLay3UGzv3aANr 75nnUUj6/TL5Waxrl/QUnu/BPtrh9maD0R21A6a2HJ6mwLlhIwUqubMDZ68nDw99fDHf hJig== X-Gm-Message-State: APjAAAXMlAZXalfzqYpM/Cx0R0lPmJbydGeQH8C8kZ8uSYe2ELtWWrZC XWV1VyhJOKDIESbReE2xUvdKXWCbz/0= X-Google-Smtp-Source: APXvYqyUAxx1/zJ6on6c1Dj9UNuN3zylY3ZgaoNYxmxea1rF+cz0ibCIgbQEAcmHbeEwobHtnzm+/Q== X-Received: by 2002:a63:f814:: with SMTP id n20mr13440185pgh.318.1576194380117; Thu, 12 Dec 2019 15:46:20 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id v16sm8442495pfn.77.2019.12.12.15.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2019 15:46:19 -0800 (PST) Date: Thu, 12 Dec 2019 15:46:17 -0800 From: Bjorn Andersson To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, agross@kernel.org, swboyd@chromium.org, stephan@gerhold.net, olof@lixom.net, Daniel Lezcano , linux-pm@vger.kernel.org Subject: Re: [PATCH v2] drivers: thermal: tsens: Work with old DTBs Message-ID: <20191212234617.GS3143381@builder> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 12 Dec 02:38 PST 2019, Amit Kucheria wrote: > In order for the old DTBs to continue working, the new interrupt code > must not return an error if interrupts are not defined. Don't return an > error in case of -ENXIO. > > Fixes: 634e11d5b450a ("drivers: thermal: tsens: Add interrupt support") > Suggested-by: Stephan Gerhold > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson > --- > drivers/thermal/qcom/tsens.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 015e7d2015985..0e7cf52369326 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -110,6 +110,9 @@ static int tsens_register(struct tsens_priv *priv) > irq = platform_get_irq_byname(pdev, "uplow"); > if (irq < 0) { > ret = irq; > + /* For old DTs with no IRQ defined */ > + if (irq == -ENXIO) > + ret = 0; > goto err_put_device; > } > > -- > 2.20.1 >