Re: [PATCH 33/58] serial/f81534: Don't check port->sysrq

Johan Hovold
2019-12-16T12:10:57Z

On Fri, Dec 13, 2019 at 12:06:32AM +0000, Dmitry Safonov wrote:
> usb_serial_handle_sysrq_char() already checks it.
>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---
> drivers/usb/serial/f81534.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/serial/f81534.c b/drivers/usb/serial/f81534.c
> index 2b39bda035c7..67a8e343eba1 100644
> --- a/drivers/usb/serial/f81534.c
> +++ b/drivers/usb/serial/f81534.c
> @@ -1238,10 +1238,8 @@ static void f81534_process_per_serial_block(struct usb_serial_port *port,
> schedule_work(&port_priv->lsr_work);
> }
>
> - if (port->port.console && port->sysrq) {
> - if (usb_serial_handle_sysrq_char(port, data[i]))
> - continue;
> - }
> + if (usb_serial_handle_sysrq_char(port, data[i]))
> + continue;

This is unrelated to the rest of the series.

Please break all usb-serial patches out of this series and submit them
to me and the usb list for review.

Johan