From: Lee Jones <lee.jones@linaro.org>
To: Orson Zhai <orson.zhai@spreadtrum.com>
Cc: Rob Herring <robh@kernel.org>, Orson Zhai <orson.zhai@unisoc.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
baolin.wang@unisoc.com, kevin.tang@unisoc.com,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
liangcai.fan@unisoc.com, orsonzhai@gmail.com
Subject: Re: [PATCH v3] mfd: syscon: Add arguments support for syscon reference
Date: Fri, 13 Dec 2019 08:23:36 +0000 [thread overview]
Message-ID: <20191213082336.GD3468@dell> (raw)
In-Reply-To: <20191213024935.GD9271@lenovo>
On Fri, 13 Dec 2019, Orson Zhai wrote:
> Hi Lee and Rob,
>
> On Wed, Dec 11, 2019 at 02:55:39PM +0100, Arnd Bergmann wrote:
> > On Wed, Dec 11, 2019 at 5:09 AM Orson Zhai <orson.zhai@unisoc.com> wrote:
> > >
> > > There are a lot of similar global registers being used across multiple SoCs
> > > from Unisoc. But most of these registers are assigned with different offset
> > > for different SoCs. It is hard to handle all of them in an all-in-one
> > > kernel image.
> > >
> > > Add a helper function to get regmap with arguments where we could put some
> > > extra information such as the offset value.
> > >
> > > Signed-off-by: Orson Zhai <orson.zhai@unisoc.com>
> > > Tested-by: Baolin Wang <baolin.wang@unisoc.com>
> >
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> Does this patch look good to be applied?
>
> Or if any comments please feel free to send to me.
If it looks good to Arnd, it looks good to me.
I have quite a number of reviews to get through first though, please
bear with me and resist the urge to nag.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-12-13 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 4:08 [PATCH v3] mfd: syscon: Add arguments support for syscon reference Orson Zhai
2019-12-11 13:55 ` Arnd Bergmann
2019-12-13 2:49 ` Orson Zhai
2019-12-13 8:23 ` Lee Jones [this message]
2019-12-13 13:54 ` Orson Zhai
2020-01-15 4:51 ` Orson Zhai
2020-01-16 13:52 ` Lee Jones
2020-01-17 11:22 ` Orson Zhai
-- strict thread matches above, loose matches on Subject: below --
2020-01-17 11:16 Orson Zhai
2020-01-17 13:28 ` Lee Jones
2020-01-17 14:54 ` Arnd Bergmann
2020-01-19 1:43 ` Orson Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213082336.GD3468@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@unisoc.com \
--cc=chunyan.zhang@unisoc.com \
--cc=kevin.tang@unisoc.com \
--cc=liangcai.fan@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orson.zhai@spreadtrum.com \
--cc=orson.zhai@unisoc.com \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox