Re: [PATCH 4.19 099/243] usb: dwc3: debugfs: Properly print/set link state for HS

Thinh Nguyen
2019-12-13T20:41:00Z

Hi,

Pavel Machek wrote:
> On Wed 2019-12-11 16:04:21, Greg Kroah-Hartman wrote:
>> From: Thinh Nguyen <thinh.nguyen@synopsys.com>
>>
>> [ Upstream commit 0d36dede457873404becd7c9cb9d0f2bcfd0dcd9 ]
>>
>> Highspeed device and below has different state names than superspeed and
>> higher. Add proper checks and printouts of link states for highspeed and
>> below.
> This is debugfs, so I don't believe it was suitable for stable in the
> first place, but....
>
>
>> + case DWC3_LINK_STATE_RESUME:
>> + return "Resume";
>> + default:
>> + return "UNKNOWN link state\n";
>> + }
> You may want to delete \n here, it will be duplicated if this ever
> triggers.

We already fixed it upstream:
038761ce68c2 ("usb: dwc3: debug: Remove newline printout")

> Best regards,
> Pavel

BR
Thinh