From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9368EC3497B for ; Fri, 13 Dec 2019 20:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C96C6246AC for ; Fri, 13 Dec 2019 20:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576269385; bh=ladYn8c8xl9+MFyl6aehoPQocrw/xZ3C142IjJPuxcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e2+tE1H5EALyds8BqD58r/K8IA4MfMwFyD2EA5YF7PXBZwI8Eng64yJcv0eD1bBdy n6P68hRFigAeFie5cAHbNGwR0v6OJKUwVoB4Zpu54kBkxPPBGlhHJGCpwpbTmrVs2X ZzRYemHbC2NZzJK6GByrpXWJwBLOBva+NucZZIB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726783AbfLMLco (ORCPT ); Fri, 13 Dec 2019 06:32:44 -0500 Received: from foss.arm.com ([217.140.110.172]:55758 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbfLMLco (ORCPT ); Fri, 13 Dec 2019 06:32:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4EA11045; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 30B113F718; Fri, 13 Dec 2019 03:32:43 -0800 (PST) Date: Fri, 13 Dec 2019 11:32:41 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Cc: Jeff Chang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "matthias.bgg@gmail.com" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20191213113241.GA4644@sirena.org.uk> References: <1576152740-11979-1-git-send-email-richtek.jeff.chang@gmail.com> <20191212145330.GC4310@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 13, 2019 at 07:36:15AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > Dear Mark: >=20 >=20 >=20 > Thanks for your replying. I consider that there was only one item= I should modify. So I kept resending. >=20 >=20 >=20 > Please refer my red comment after your comment. I can't tell what's in red or not, kernel development gets done with plain text e-mail. Please fix your mail configuration, it is extremely difficult to read your messages for this and other reasons. > The writes to reserved registers should be fine but things like this whic= h looks like it's configuring the input path should just be left at the chi= p default, we don't want to be configuring for particular boards since the = same driver will be used for every board with the chip. >=20 >=20 >=20 > The chip default cannot be modified anymore. How can I do if I re= ally need write these setting in our drivers? Settings should be done through some combination of userspace configuration at runtime and device tree or ACPI properties. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zdtYACgkQJNaLcl1U h9B8kwf+IpjaEaGa2G/sBNA8Uba5iLxJH77tx+EkitOF1sumwNDj1XNcuYqb9lDl ak4VjrPpISMuFyn2bA1jcGMDT9Kt7Iu9Ho2H/trihujQasAESaDskolv4ePg0XVV azTK7X98WsarZRy6EpuWWSCmF1ePPpA60fHtM3rjQbKDhAb+6VVIl6kDEeWvhwtt aPl5Twi1fjMqgPtqSdCe/aREpmiREG19zoTy/M/INreV7T5KY4ndfV/m6YNnBVss T0ambE+xjV94LIULzEsa5fno9DKIgGOmrKxunAXswLk8B4Za0Auhv7E3XBvc/CpR 7kTt0mjLMsVXjv75mbnn2BKi7Zdovw== =PyY0 -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--