Re: [PATCH] w1: omap-hdq: Simplify driver with PM runtime autosuspend

Andreas Kemnade
2019-12-16T13:48:24Z

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On Sun, 15 Dec 2019 19:16:37 -0800
Tony Lindgren <tony@atomide.com> wrote:

> * Tony Lindgren <tony@atomide.com> [191216 03:10]:
> > Hi,
> >
> > * Andreas Kemnade <andreas@kemnade.info> [191215 22:04]:
> > > On Sun, 15 Dec 2019 09:38:17 -0800
> > > If I remember correctly this thing is critical to get the hwmod out of
> > > reset but I need to examine that again:
> >
> > Thanks for testing, yes that's what I thought might cause it
> > too, but nope :)
> >
> > We currently disable interrupts for some reason after
> > the first read. That won't play with runtime PM autosuspend
> > at all as we never enable them again until the device has
> > idled. Can you try the following additional patch on top?
>
> And we should probably do the following too to make sure
> the mode is initialized before we call runtime PM.
>
CM_FCLKEN1/IDLEST1_CORE seem to behave, reading also works

With these two additional patches this deserves a
Tested-By: Andreas Kemnade <andreas@kemnade.info> # gta04

Regards,
Andreas

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]