Re: [PATCH] w1: omap-hdq: Simplify driver with PM runtime autosuspend

Tony Lindgren
2019-12-16T14:58:57Z

* Adam Ford <aford173@gmail.com> [191216 13:58]:
> On Mon, Dec 16, 2019 at 7:48 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > On Sun, 15 Dec 2019 19:16:37 -0800
> > Tony Lindgren <tony@atomide.com> wrote:
> >
> > > * Tony Lindgren <tony@atomide.com> [191216 03:10]:
> > > > Hi,
> > > >
> > > > * Andreas Kemnade <andreas@kemnade.info> [191215 22:04]:
> > > > > On Sun, 15 Dec 2019 09:38:17 -0800
> > > > > If I remember correctly this thing is critical to get the hwmod out of
> > > > > reset but I need to examine that again:
> > > >
> > > > Thanks for testing, yes that's what I thought might cause it
> > > > too, but nope :)
> > > >
> > > > We currently disable interrupts for some reason after
> > > > the first read. That won't play with runtime PM autosuspend
> > > > at all as we never enable them again until the device has
> > > > idled. Can you try the following additional patch on top?
> > >
> > > And we should probably do the following too to make sure
> > > the mode is initialized before we call runtime PM.
> > >
> > CM_FCLKEN1/IDLEST1_CORE seem to behave, reading also works
> >
> > With these two additional patches this deserves a
> > Tested-By: Andreas Kemnade <andreas@kemnade.info> # gta04
>
> Tony,
>
> Any way you can do a V2 patch with the other stuff added? Pulling the
> patches from gmail doesn't work. I think G-mail does something weird
> because they don't apply cleanly, so I have to download the patches
> from patchwork. I should be able to test it today.

OK sent out v2 with the two change folded in. The ti,mode = "1w"
still needs to be tested if anybody has a sensor to test with.
I verified the battery ds2502 gets properly detected on droid4 battery,
in "1w" mode, but so far no luck actually reading the nvmem with the
newish w1_ds250x driver.

Regards,

Tony