From: Jules Irenge <jbi.octave@gmail.com>
To: boqun.feng@gmail.com
Cc: tglx@linutronix.de, maz@kernel.org, linux-kernel@vger.kernel.org,
Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH 2/2] kernel: irq: add must_hold() annotation
Date: Mon, 16 Dec 2019 14:42:08 +0000 [thread overview]
Message-ID: <20191216144208.29852-2-jbi.octave@gmail.com> (raw)
In-Reply-To: <20191216144208.29852-1-jbi.octave@gmail.com>
Add __must_hold() annotation to remove issue detected by sparse tool.
warning: context imbalance in irq_wait_for_poll - unexpected unlock
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
kernel/irq/spurious.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 2ed97a7c9b2a..f865e5f4d382 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -34,6 +34,7 @@ static atomic_t irq_poll_active;
* true and let the handler run.
*/
bool irq_wait_for_poll(struct irq_desc *desc)
+ __must_hold(&desc->lock)
{
if (WARN_ONCE(irq_poll_cpu == smp_processor_id(),
"irq poll in progress on cpu %d for irq %d\n",
--
2.23.0
next prev parent reply other threads:[~2019-12-16 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 14:42 [PATCH 1/2] kernel: irq: add releases() notation Jules Irenge
2019-12-16 14:42 ` Jules Irenge [this message]
2020-01-09 17:10 ` [tip: irq/core] genirq: Add missing __must_hold() sparse annotation tip-bot2 for Jules Irenge
2020-01-09 17:10 ` [tip: irq/core] genirq: Add missing __releases() " tip-bot2 for Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216144208.29852-2-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox