From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DEEC43603 for ; Mon, 16 Dec 2019 14:58:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF799206E0 for ; Mon, 16 Dec 2019 14:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728241AbfLPO6z (ORCPT ); Mon, 16 Dec 2019 09:58:55 -0500 Received: from muru.com ([72.249.23.125]:48456 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbfLPO6z (ORCPT ); Mon, 16 Dec 2019 09:58:55 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7D591810D; Mon, 16 Dec 2019 14:59:33 +0000 (UTC) Date: Mon, 16 Dec 2019 06:58:51 -0800 From: Tony Lindgren To: Adam Ford Cc: Andreas Kemnade , Evgeniy Polyakov , Greg Kroah-Hartman , Linux Kernel Mailing List , Linux-OMAP , "Andrew F . Davis" , "H . Nikolaus Schaller" , Vignesh R Subject: Re: [PATCH] w1: omap-hdq: Simplify driver with PM runtime autosuspend Message-ID: <20191216145851.GN35479@atomide.com> References: <20191215173817.47918-1-tony@atomide.com> <20191215230331.645b9064@aktux> <20191216030948.GL35479@atomide.com> <20191216031637.GM35479@atomide.com> <20191216130536.5935a587@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Adam Ford [191216 13:58]: > On Mon, Dec 16, 2019 at 7:48 AM Andreas Kemnade wrote: > > > > On Sun, 15 Dec 2019 19:16:37 -0800 > > Tony Lindgren wrote: > > > > > * Tony Lindgren [191216 03:10]: > > > > Hi, > > > > > > > > * Andreas Kemnade [191215 22:04]: > > > > > On Sun, 15 Dec 2019 09:38:17 -0800 > > > > > If I remember correctly this thing is critical to get the hwmod out of > > > > > reset but I need to examine that again: > > > > > > > > Thanks for testing, yes that's what I thought might cause it > > > > too, but nope :) > > > > > > > > We currently disable interrupts for some reason after > > > > the first read. That won't play with runtime PM autosuspend > > > > at all as we never enable them again until the device has > > > > idled. Can you try the following additional patch on top? > > > > > > And we should probably do the following too to make sure > > > the mode is initialized before we call runtime PM. > > > > > CM_FCLKEN1/IDLEST1_CORE seem to behave, reading also works > > > > With these two additional patches this deserves a > > Tested-By: Andreas Kemnade # gta04 > > Tony, > > Any way you can do a V2 patch with the other stuff added? Pulling the > patches from gmail doesn't work. I think G-mail does something weird > because they don't apply cleanly, so I have to download the patches > from patchwork. I should be able to test it today. OK sent out v2 with the two change folded in. The ti,mode = "1w" still needs to be tested if anybody has a sensor to test with. I verified the battery ds2502 gets properly detected on droid4 battery, in "1w" mode, but so far no luck actually reading the nvmem with the newish w1_ds250x driver. Regards, Tony