* [PATCH] mfd: ab8500: Fix ab8500-clk typo
@ 2019-12-11 11:46 Linus Walleij
2019-12-11 17:18 ` Stephan Gerhold
2019-12-16 15:22 ` Lee Jones
0 siblings, 2 replies; 5+ messages in thread
From: Linus Walleij @ 2019-12-11 11:46 UTC (permalink / raw)
To: lee.jones, linux-kernel; +Cc: Linus Walleij, Stephan Gerhold
Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
has a typo error renaming "ab8500-clk" to "abx500-clk"
with the result att ALSA SoC audio broke as the clock
driver was not probing anymore. Fixed it up.
Cc: Stephan Gerhold <stephan@gerhold.net>
Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/mfd/ab8500-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index bafc729fc434..3c6fda68e6bc 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -631,8 +631,8 @@ static const struct mfd_cell ab8500_devs[] = {
NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),
OF_MFD_CELL("ab8500-regulator",
NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),
- OF_MFD_CELL("abx500-clk",
- NULL, NULL, 0, 0, "stericsson,abx500-clk"),
+ OF_MFD_CELL("ab8500-clk",
+ NULL, NULL, 0, 0, "stericsson,ab8500-clk"),
OF_MFD_CELL("ab8500-gpadc",
NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),
OF_MFD_CELL("ab8500-rtc",
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo
2019-12-11 11:46 [PATCH] mfd: ab8500: Fix ab8500-clk typo Linus Walleij
@ 2019-12-11 17:18 ` Stephan Gerhold
2019-12-16 15:22 ` Lee Jones
1 sibling, 0 replies; 5+ messages in thread
From: Stephan Gerhold @ 2019-12-11 17:18 UTC (permalink / raw)
To: Linus Walleij; +Cc: lee.jones, linux-kernel
On Wed, Dec 11, 2019 at 12:46:39PM +0100, Linus Walleij wrote:
> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> has a typo error renaming "ab8500-clk" to "abx500-clk"
> with the result att ALSA SoC audio broke as the clock
> driver was not probing anymore. Fixed it up.
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> drivers/mfd/ab8500-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index bafc729fc434..3c6fda68e6bc 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -631,8 +631,8 @@ static const struct mfd_cell ab8500_devs[] = {
> NULL, NULL, 0, 0, "stericsson,ab8500-ext-regulator"),
> OF_MFD_CELL("ab8500-regulator",
> NULL, NULL, 0, 0, "stericsson,ab8500-regulator"),
> - OF_MFD_CELL("abx500-clk",
> - NULL, NULL, 0, 0, "stericsson,abx500-clk"),
> + OF_MFD_CELL("ab8500-clk",
> + NULL, NULL, 0, 0, "stericsson,ab8500-clk"),
> OF_MFD_CELL("ab8500-gpadc",
> NULL, NULL, 0, 0, "stericsson,ab8500-gpadc"),
> OF_MFD_CELL("ab8500-rtc",
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo
2019-12-11 11:46 [PATCH] mfd: ab8500: Fix ab8500-clk typo Linus Walleij
2019-12-11 17:18 ` Stephan Gerhold
@ 2019-12-16 15:22 ` Lee Jones
2020-01-17 10:17 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Lee Jones @ 2019-12-16 15:22 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, Stephan Gerhold
On Wed, 11 Dec 2019, Linus Walleij wrote:
> Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> has a typo error renaming "ab8500-clk" to "abx500-clk"
> with the result att ALSA SoC audio broke as the clock
> driver was not probing anymore. Fixed it up.
>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mfd/ab8500-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo
2019-12-16 15:22 ` Lee Jones
@ 2020-01-17 10:17 ` Linus Walleij
2020-01-17 13:41 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2020-01-17 10:17 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel@vger.kernel.org, Stephan Gerhold
On Mon, Dec 16, 2019 at 4:22 PM Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 11 Dec 2019, Linus Walleij wrote:
>
> > Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> > has a typo error renaming "ab8500-clk" to "abx500-clk"
> > with the result att ALSA SoC audio broke as the clock
> > driver was not probing anymore. Fixed it up.
> >
> > Cc: Stephan Gerhold <stephan@gerhold.net>
> > Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > drivers/mfd/ab8500-core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, thanks.
For some reason this patch doesn't appear in mainline or linux-next,
I guess it fell off the planet somehow :D
Or do I look in the wrong place?
Lee, could you look into it?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mfd: ab8500: Fix ab8500-clk typo
2020-01-17 10:17 ` Linus Walleij
@ 2020-01-17 13:41 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2020-01-17 13:41 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel@vger.kernel.org, Stephan Gerhold
On Fri, 17 Jan 2020, Linus Walleij wrote:
> On Mon, Dec 16, 2019 at 4:22 PM Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 11 Dec 2019, Linus Walleij wrote:
> >
> > > Commit f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> > > has a typo error renaming "ab8500-clk" to "abx500-clk"
> > > with the result att ALSA SoC audio broke as the clock
> > > driver was not probing anymore. Fixed it up.
> > >
> > > Cc: Stephan Gerhold <stephan@gerhold.net>
> > > Fixes: f4d41ad84433 ("mfd: ab8500: Example using new OF_MFD_CELL MACRO")
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > > drivers/mfd/ab8500-core.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Applied, thanks.
>
> For some reason this patch doesn't appear in mainline or linux-next,
> I guess it fell off the planet somehow :D
>
> Or do I look in the wrong place?
>
> Lee, could you look into it?
It was there, just not pushed in a while.
Pushed now, should be in -next tomorrow.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-17 13:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 11:46 [PATCH] mfd: ab8500: Fix ab8500-clk typo Linus Walleij
2019-12-11 17:18 ` Stephan Gerhold
2019-12-16 15:22 ` Lee Jones
2020-01-17 10:17 ` Linus Walleij
2020-01-17 13:41 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox