From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA445C43603 for ; Mon, 16 Dec 2019 18:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B263A21582 for ; Mon, 16 Dec 2019 18:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521353; bh=9cbr/GasuS7QSyHWgJSVGLmTNURye9a+SzXMS0zRzyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zOE4tk+8E8vIN4EhOSwAlerQuH4CtmOjM4ZotSDXjCsCbrJF/K3I2KgpujRsMREWj mtk7B9PAAD2aXyGkU9W/LZVIU1md0QD/eRKJsCcwGhcm27kmtojBVcrr/qaoE9tfjS /yxu/E1RVBruDyn2DnOS3x0RFWM9iM6isf2+zJeo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730475AbfLPSfv (ORCPT ); Mon, 16 Dec 2019 13:35:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:48620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729800AbfLPSHc (ORCPT ); Mon, 16 Dec 2019 13:07:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F267A20700; Mon, 16 Dec 2019 18:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576519652; bh=9cbr/GasuS7QSyHWgJSVGLmTNURye9a+SzXMS0zRzyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FxQAB80lrXdIGsEKuLjbEMwS3xVXINHLg0Pf7CaJ1OwiHQyxvf3SKJzK5pbe7kEju 1oNohA4056Y9Y82coMVjd2K3nc8a75PwUYxw8/1VLUCjeI2z2CV/u3H86tk4yFJCg4 g7bAeXYb32ohf5rbdpavQUxG3rv6REDfqizQng0E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 5.3 014/180] staging: rtl8188eu: fix interface sanity check Date: Mon, 16 Dec 2019 18:47:34 +0100 Message-Id: <20191216174808.901670398@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191216174806.018988360@linuxfoundation.org> References: <20191216174806.018988360@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 74ca34118a0e05793935d804ccffcedd6eb56596 upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: c2478d39076b ("staging: r8188eu: Add files for new driver - part 20") Cc: stable # 3.12 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191210114751.5119-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -70,7 +70,7 @@ static struct dvobj_priv *usb_dvobj_init phost_conf = pusbd->actconfig; pconf_desc = &phost_conf->desc; - phost_iface = &usb_intf->altsetting[0]; + phost_iface = usb_intf->cur_altsetting; piface_desc = &phost_iface->desc; pdvobjpriv->NumInterfaces = pconf_desc->bNumInterfaces;