From: Vinod Koul <vkoul@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets
Date: Tue, 17 Dec 2019 00:02:31 +0530 [thread overview]
Message-ID: <20191216183232.1570675-1-vkoul@kernel.org> (raw)
The reset described is the phy reset so it should be named ufsphy, so
update it and add the UFS card reset
Earlier reset description was incorrect as phy reset was pointed to
'rst' as well as 'ufsphy' so both phy and core attempted to reset this
causing UFS to not come up. This was discovered with 870b1279c7a0
("scsi: ufs-qcom: Add reset control support for host controller")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index f36d621a53e2..6a351e0cb3a6 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -517,8 +517,9 @@
phy-names = "ufsphy";
lanes-per-direction = <2>;
#reset-cells = <1>;
- resets = <&gcc GCC_UFS_PHY_BCR>;
- reset-names = "rst";
+ resets = <&gcc GCC_UFS_PHY_BCR>,
+ <&gcc GCC_UFS_CARD_BCR>;
+ reset-names = "ufsphy", "rst";
clock-names =
"core_clk",
--
2.23.0
next reply other threads:[~2019-12-16 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 18:32 Vinod Koul [this message]
2019-12-16 18:32 ` [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Add reset line for UFS Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216183232.1570675-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox