From: Eric Biggers <ebiggers@kernel.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: remove unneeded semicolon
Date: Mon, 16 Dec 2019 10:43:42 -0800 [thread overview]
Message-ID: <20191216184341.GE139479@gmail.com> (raw)
In-Reply-To: <20191216105848.10669-1-chenzhou10@huawei.com>
On Mon, Dec 16, 2019 at 06:58:48PM +0800, Chen Zhou wrote:
> Fixes coccicheck warning:
>
> ./include/linux/crypto.h:573:2-3: Unneeded semicolon
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> include/linux/crypto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 23365a9..5446efe 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -570,7 +570,7 @@ static inline int crypto_wait_req(int err, struct crypto_wait *wait)
> reinit_completion(&wait->completion);
> err = wait->err;
> break;
> - };
> + }
>
> return err;
> }
> --
As long as you're changing this, perhaps also change the 'switch' to an 'if' and
delete the extra blank line? I.e.:
static inline int crypto_wait_req(int err, struct crypto_wait *wait)
{
if (err == -EINPROGRESS || err == -EBUSY) {
wait_for_completion(&wait->completion);
reinit_completion(&wait->completion);
err = wait->err;
}
return err;
}
next prev parent reply other threads:[~2019-12-16 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 10:58 [PATCH] crypto: remove unneeded semicolon Chen Zhou
2019-12-16 18:43 ` Eric Biggers [this message]
2019-12-27 10:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216184341.GE139479@gmail.com \
--to=ebiggers@kernel.org \
--cc=chenzhou10@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox