public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available
Date: Mon, 16 Dec 2019 13:04:07 -0800	[thread overview]
Message-ID: <20191216210407.GR35479@atomide.com> (raw)
In-Reply-To: <1ff8ae4b-5de3-4fdf-7318-d33398dc7fc8@ti.com>

* Andrew F. Davis <afd@ti.com> [191216 20:57]:
> Looks like the TI quirk idea is not moving forward, even the QCOM quirk
> looks like it may get kicked out. arm_smccc_smc() will remain only for
> SMCCC compliant calls, but it looks like a generic arm_smc() wouldn't be
> too opposed upstream.

Yes so it seems.

> Either way this patch would still be valid as when OP-TEE is present
> then arm_smccc_smc() will be the right call to make, how we handle the
> legacy calls can be sorted out later if a generic SMC call is implemented.

Please see my comment regarding this patch earlier in this thread
pasted below for convenience:

* Tony Lindgren <tony@atomide.com> [191119 16:22]:
> In any case, you should do the necessary checks for HAVE_ARM_SMCCC
> only once during init. I'm not sure how much checking for
> "/firmware/optee" helps here, sounds like we have a broken system
> if the firmware is not there while the arm_smccc_smc() should
> still work just fine :)

So only check once during init. And during init, you should probably
also check that arm_smccc_smc() actually infd optee if
"/firmware/optee" is set, and only then set set the right function
pointer or some flag.

Regards,

Tony

  reply	other threads:[~2019-12-16 21:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 16:52 [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Andrew F. Davis
2019-11-18 21:57 ` Tony Lindgren
2019-11-18 22:13   ` Andrew F. Davis
2019-11-18 22:31     ` Tony Lindgren
2019-11-19  1:13       ` Andrew F. Davis
2019-11-19 16:21         ` Tony Lindgren
2019-11-19 16:30           ` Tony Lindgren
2019-11-19 16:30           ` Andrew F. Davis
2019-11-19 16:42             ` Tony Lindgren
2019-11-19 18:05               ` Tony Lindgren
2019-11-19 18:20                 ` Andrew F. Davis
2019-11-19 18:32                   ` Tony Lindgren
2019-11-19 18:50                     ` Andrew F. Davis
2019-11-19 19:07                       ` Tony Lindgren
2019-11-19 19:12                         ` Andrew F. Davis
2019-11-19 19:20                           ` Tony Lindgren
2019-11-19 19:35                             ` Andrew F. Davis
2019-11-19 19:44                               ` Tony Lindgren
2019-11-19 19:59                                 ` Andrew F. Davis
2019-12-16 20:56                                   ` Andrew F. Davis
2019-12-16 21:04                                     ` Tony Lindgren [this message]
2019-12-16 22:34                                       ` Andrew F. Davis
2019-12-16 22:41                                         ` Tony Lindgren
2019-12-17 13:14                                           ` Andrew F. Davis
2019-12-17 15:07                                             ` Tony Lindgren
2019-12-17 17:01                                               ` Andrew F. Davis
2019-12-17 17:11                                                 ` Tony Lindgren
2019-12-17 17:18                                                   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216210407.GR35479@atomide.com \
    --to=tony@atomide.com \
    --cc=afd@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox