From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C73C43603 for ; Mon, 16 Dec 2019 21:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52D9921D7D for ; Mon, 16 Dec 2019 21:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfLPVEL (ORCPT ); Mon, 16 Dec 2019 16:04:11 -0500 Received: from muru.com ([72.249.23.125]:48520 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfLPVEK (ORCPT ); Mon, 16 Dec 2019 16:04:10 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 84397810D; Mon, 16 Dec 2019 21:04:49 +0000 (UTC) Date: Mon, 16 Dec 2019 13:04:07 -0800 From: Tony Lindgren To: "Andrew F. Davis" Cc: Mark Rutland , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Message-ID: <20191216210407.GR35479@atomide.com> References: <9e15c170-c9fa-778c-d998-bd1111a6390d@ti.com> <20191119183247.GN35479@atomide.com> <20191119190721.GO35479@atomide.com> <7fa11037-8d33-2274-c8cc-80e9630b38b0@ti.com> <20191119192029.GP35479@atomide.com> <0ad31b32-712e-5bef-5645-0336dfec99cc@ti.com> <20191119194425.GQ35479@atomide.com> <1ff8ae4b-5de3-4fdf-7318-d33398dc7fc8@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ff8ae4b-5de3-4fdf-7318-d33398dc7fc8@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andrew F. Davis [191216 20:57]: > Looks like the TI quirk idea is not moving forward, even the QCOM quirk > looks like it may get kicked out. arm_smccc_smc() will remain only for > SMCCC compliant calls, but it looks like a generic arm_smc() wouldn't be > too opposed upstream. Yes so it seems. > Either way this patch would still be valid as when OP-TEE is present > then arm_smccc_smc() will be the right call to make, how we handle the > legacy calls can be sorted out later if a generic SMC call is implemented. Please see my comment regarding this patch earlier in this thread pasted below for convenience: * Tony Lindgren [191119 16:22]: > In any case, you should do the necessary checks for HAVE_ARM_SMCCC > only once during init. I'm not sure how much checking for > "/firmware/optee" helps here, sounds like we have a broken system > if the firmware is not there while the arm_smccc_smc() should > still work just fine :) So only check once during init. And during init, you should probably also check that arm_smccc_smc() actually infd optee if "/firmware/optee" is set, and only then set set the right function pointer or some flag. Regards, Tony