From: Peter Xu <peterx@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
peterx@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH v2 2/3] MIPS: smp: Remove tick_broadcast_count
Date: Mon, 16 Dec 2019 16:31:24 -0500 [thread overview]
Message-ID: <20191216213125.9536-3-peterx@redhat.com> (raw)
In-Reply-To: <20191216213125.9536-1-peterx@redhat.com>
Now smp_call_function_single_async() provides the protection that
we'll return with -EBUSY if the csd object is still pending, then we
don't need the tick_broadcast_count counter any more.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
arch/mips/kernel/smp.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index f510c00bda88..0678901c214d 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -696,21 +696,16 @@ EXPORT_SYMBOL(flush_tlb_one);
#ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
-static DEFINE_PER_CPU(atomic_t, tick_broadcast_count);
static DEFINE_PER_CPU(call_single_data_t, tick_broadcast_csd);
void tick_broadcast(const struct cpumask *mask)
{
- atomic_t *count;
call_single_data_t *csd;
int cpu;
for_each_cpu(cpu, mask) {
- count = &per_cpu(tick_broadcast_count, cpu);
csd = &per_cpu(tick_broadcast_csd, cpu);
-
- if (atomic_inc_return(count) == 1)
- smp_call_function_single_async(cpu, csd);
+ smp_call_function_single_async(cpu, csd);
}
}
@@ -718,7 +713,6 @@ static void tick_broadcast_callee(void *info)
{
int cpu = smp_processor_id();
tick_receive_broadcast();
- atomic_set(&per_cpu(tick_broadcast_count, cpu), 0);
}
static int __init tick_broadcast_init(void)
--
2.23.0
next prev parent reply other threads:[~2019-12-16 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 21:31 [PATCH v2 0/3] smp: Allow smp_call_function_single_async() to insert locked csd Peter Xu
2019-12-16 21:31 ` [PATCH v2 1/3] " Peter Xu
2020-03-06 14:42 ` [tip: smp/core] " tip-bot2 for Peter Xu
2019-12-16 21:31 ` Peter Xu [this message]
2020-03-06 14:42 ` [tip: smp/core] MIPS: smp: Remove tick_broadcast_count tip-bot2 for Peter Xu
2019-12-16 21:31 ` [PATCH v2 3/3] sched: Remove rq.hrtick_csd_pending Peter Xu
2020-03-06 14:42 ` [tip: smp/core] sched/core: " tip-bot2 for Peter Xu
2020-01-06 16:40 ` [PATCH v2 0/3] smp: Allow smp_call_function_single_async() to insert locked csd Peter Xu
2020-02-17 16:04 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216213125.9536-3-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox