From: Joerg Roedel <jroedel@suse.de>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iommu: set group default domain before creating direct mappings
Date: Tue, 17 Dec 2019 11:45:35 +0100 [thread overview]
Message-ID: <20191217104535.GB28651@suse.de> (raw)
In-Reply-To: <49bca506-1f6a-ab2d-fac0-302073737af7@linux.intel.com>
On Wed, Dec 11, 2019 at 08:54:21AM +0800, Lu Baolu wrote:
> On 12/11/19 2:56 AM, Jerry Snitselaar wrote:
> > iommu_group_create_direct_mappings uses group->default_domain, but
> > right after it is called, request_default_domain_for_dev calls
> > iommu_domain_free for the default domain, and sets the group default
> > domain to a different domain. Move the
> > iommu_group_create_direct_mappings call to after the group default
> > domain is set, so the direct mappings get associated with that domain.
> >
> > Cc: Joerg Roedel <jroedel@suse.de>
> > Cc: Lu Baolu <baolu.lu@linux.intel.com>
>
> This fix looks good to me.
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Applied, thanks.
prev parent reply other threads:[~2019-12-17 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 18:56 [PATCH] iommu: set group default domain before creating direct mappings Jerry Snitselaar
2019-12-11 0:54 ` Lu Baolu
2019-12-17 10:45 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217104535.GB28651@suse.de \
--to=jroedel@suse.de \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox