From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1798BC43603 for ; Tue, 17 Dec 2019 12:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E02C4206D8 for ; Tue, 17 Dec 2019 12:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576586173; bh=B7h76drzd6gyW48HzKwrGBmdAS3OiSGmCCDzI4QGaKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SKHvyT3H6RMhLO/+7jIbuAH1f7yc/JRR1on3YarthfRxe7M3eDtfUcNgIo63UNLsS lNQEpqTZYIVLC6Kwxn6m8hoIPCKCFSJuQq9De2JyuOIM+FllC7onjQTB9Vr+m6zuH8 crHvDfmQ18Cg2ytBe8TZ5V+J+PRuJfc1tuG3sEg0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbfLQMgN (ORCPT ); Tue, 17 Dec 2019 07:36:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:44612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbfLQMgM (ORCPT ); Tue, 17 Dec 2019 07:36:12 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61696206D8; Tue, 17 Dec 2019 12:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576586171; bh=B7h76drzd6gyW48HzKwrGBmdAS3OiSGmCCDzI4QGaKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cX82lLzPKCfZGg+79MXAntIsqijJY92TduKqfDQ0Q2kBtpEeoh31St5pPYq/uxfOp Sncy45woPUxOY5bQXi8jgHZJsJOyi+QDGutqsEFoVe6XNzAOrfZonrEcnQoSwMZzRH k3fvgAamTDQFIklI4oGO9urS09oEsPPXtYZNaZi4= Date: Tue, 17 Dec 2019 13:36:09 +0100 From: Greg KH To: Scott Schafer Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/23] staging: qlge: Fix WARNING: Missing a blank line after declarations Message-ID: <20191217123609.GA3161277@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 12:12:32PM -0600, Scott Schafer wrote: > Fix WARNING: Missing a blank line after declarations for the follig > files: > qlge.h > qlge_dbg.c > qlge_main.c > qlge_mpi.c > > Signed-off-by: Scott Schafer > --- > drivers/staging/qlge/qlge.h | 1 + > drivers/staging/qlge/qlge_dbg.c | 5 +++++ > drivers/staging/qlge/qlge_main.c | 13 +++++++++++++ > drivers/staging/qlge/qlge_mpi.c | 6 ++++++ > 4 files changed, 25 insertions(+) > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index 4bc5d5fce9bf..89502a8300f6 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2227,6 +2227,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr) > static inline u32 ql_read_sh_reg(__le32 *addr) > { > u32 reg; > + You are adding trailing whitespace on every one of your newlines you are adding :( I suggest using an editor that shows this up as a bright red mark, it makes it more obvious you are doing something wrong. Also try running checkpatch.pl on the patches you are writing to make sure you do not add more errors/warnings when you are trying to fix them up. thanks, greg k-h