Re: [PATCH 12/12] perf maps: Set maps pointer in the kmap area for kernel maps

Jiri Olsa
2019-12-18T09:07:22Z

On Tue, Dec 17, 2019 at 11:48:28AM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

>
> @@ -1098,7 +1097,6 @@ __machine__create_kernel_maps(struct machine *machine, struct dso *kernel)
> if (!kmap)
> return -1;
>
> - kmap->kmaps = &machine->kmaps;
> maps__insert(&machine->kmaps, map);
>
> return 0;
> diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
> index fdd5bddb3075..a2cdfe62df94 100644
> --- a/tools/perf/util/map.c
> +++ b/tools/perf/util/map.c
> @@ -223,7 +223,7 @@ struct map *map__new(struct machine *machine, u64 start, u64 len,
> * they are loaded) and for vmlinux, where only after we load all the
> * symbols we'll know where it starts and ends.
> */
> -struct map *map__new2(u64 start, struct dso *dso)
> +struct map *map__new2(u64 start, struct dso *dso, struct maps *kmaps)

hum, how about map__new? kernel maps could go throught that as well, right?

jirka