From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76184C43603 for ; Tue, 17 Dec 2019 17:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4925524655 for ; Tue, 17 Dec 2019 17:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbfLQRSq (ORCPT ); Tue, 17 Dec 2019 12:18:46 -0500 Received: from muru.com ([72.249.23.125]:48990 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbfLQRSq (ORCPT ); Tue, 17 Dec 2019 12:18:46 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 60EB18116; Tue, 17 Dec 2019 17:19:25 +0000 (UTC) Date: Tue, 17 Dec 2019 09:18:42 -0800 From: Tony Lindgren To: "Andrew F. Davis" Cc: Mark Rutland , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available Message-ID: <20191217171842.GZ35479@atomide.com> References: <20191119194425.GQ35479@atomide.com> <1ff8ae4b-5de3-4fdf-7318-d33398dc7fc8@ti.com> <20191216210407.GR35479@atomide.com> <9adad579-98b4-f228-caf3-f4996dcaecda@ti.com> <20191216224105.GS35479@atomide.com> <35e4b682-0d2f-23b1-6df4-428c6bcb4d59@ti.com> <20191217150732.GW35479@atomide.com> <8d5d098f-26cb-c436-ec7b-bed0ed0a9ced@ti.com> <20191217171108.GY35479@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217171108.GY35479@atomide.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [191217 17:11]: > * Andrew F. Davis [191217 17:02]: > > On 12/17/19 10:07 AM, Tony Lindgren wrote: > > > * Andrew F. Davis [191217 13:14]: > > >> On 12/16/19 5:41 PM, Tony Lindgren wrote: > > >>> Please just add omap_early_initcall() to omap-secure.c while at it > > >>> to deal with this. > > >> > > >> omap_early_initcall()s are not called until after all the SMC calls have > > >> already happened. > > > > > > Oh OK. Then let's just add omap_secure_init() that's called from > > > *_init_early() as late as possible. We will have more use for that > > > init later on too. > > > > > > > > > You mean add a call to this omap_secure_init() to every boards init > > function? > > Yes please. We also have some SoCs that need clocks enabled > and disabled for omap_smc2() so we can then use that to > intialize the clocks as needed. And please add the call to omap_secure_init() the SoC specific *_init_early() functions in: $ git grep 'void __init ' arch/arm/mach-omap2/io.c | grep early ... Regards, Tony