From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 3/3] perf report: support hotkey to let user select any event for sorting
Date: Wed, 18 Dec 2019 08:47:08 +0100 [thread overview]
Message-ID: <20191218074708.GC19062@krava> (raw)
In-Reply-To: <20191218022443.18958-3-yao.jin@linux.intel.com>
On Wed, Dec 18, 2019 at 10:24:43AM +0800, Jin Yao wrote:
> When performing "perf report --group", it shows the event group information
> together. In previous patch, we have supported a new option "--group-sort-idx"
> to sort the output by the event at the index n in event group.
>
> It would be nice if we can use a hotkey in browser to select a event
> to sort.
>
> For example,
>
> # perf report --group
>
> Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
> Overhead Command Shared Object Symbol
> 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
> 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
> 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
> 1.56% 0.01% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494ce
> 1.56% 0.00% 0.00% 0.00% mgen [kernel.kallsyms] [k] task_tick_fair
> 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
> 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
> 0.00% 0.03% 0.00% 0.00% gsd-color libglib-2.0.so.0.5600.4 [.] g_main_context_check
> 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] apic_timer_interrupt
> 0.00% 0.03% 0.00% 0.00% swapper [kernel.kallsyms] [k] check_preempt_curr
>
> When user press hotkey '3' (event index, starting from 0), it indicates
> to sort output by the forth event in group.
>
> Samples: 12K of events 'cpu/instructions,period=2000003/, cpu/cpu-cycles,period=200003/, ...
> Overhead Command Shared Object Symbol
> 92.19% 98.68% 0.00% 93.30% mgen mgen [.] LOOP1
> 0.00% 0.13% 0.00% 6.08% swapper [kernel.kallsyms] [k] intel_idle
> 3.12% 0.29% 0.00% 0.16% gsd-color libglib-2.0.so.0.5600.4 [.] 0x0000000000049515
> 0.00% 0.00% 0.00% 0.06% swapper [kernel.kallsyms] [k] hrtimer_start_range_ns
> 1.56% 0.03% 0.00% 0.04% gsd-color libglib-2.0.so.0.5600.4 [.] 0x00000000000494b7
> 0.00% 0.15% 0.00% 0.04% perf [kernel.kallsyms] [k] smp_call_function_single
> 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] update_curr
> 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] apic_timer_interrupt
> 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] native_apic_msr_eoi_write
> 0.00% 0.00% 0.00% 0.02% mgen [kernel.kallsyms] [k] __update_load_avg_se
when I press 0...9 I'm getting extra columns:
Samples: 134 of events 'anon group { cycles:u, instructions:u, cache-misses:u, cycles:u, instructions:u }', Event count (approx.): 7107344
Overhead Command Shared Object Symbol Self
17.95% 41.20% 0.00% 12.44% 41.30% ls libc-2.29.so [.] __strcoll_l 17.95% 41.20% 0.00% 12.44% 41.30% N/A
0.00% 13.22% 0.00% 0.00% 0.00% ls ls [.] 0x000000000000871c 0.00% 13.22% 0.00% 0.00% 0.00% N/A
8.32% 11.49% 0.00% 2.62% 9.34% ls ld-2.29.so [.] do_lookup_x 8.32% 11.49% 0.00% 2.62% 9.34% N/A
0.00% 8.29% 31.18% 13.34% 3.05% ls ld-2.29.so [.] _dl_lookup_symbol_x 0.00% 8.29% 31.18% 13.34% 3.05% N/A
0.00% 6.47% 0.00% 0.00% 0.00% ls libc-2.29.so [.] __strlen_avx2 0.00% 6.47% 0.00% 0.00% 0.00% N/A
0.00% 5.97% 0.00% 0.00% 0.00% ls ls [.] 0x0000000000014001 0.00% 5.97% 0.00% 0.00% 0.00% N/A
5.77% 5.83% 7.79% 4.78% 5.04% ls ld-2.29.so [.] strcmp 5.77% 5.83% 7.79% 4.78% 5.04% N/A
2.31% 4.35% 8.30% 0.00% 0.00% ls ld-2.29.so [.] _dl_map_object_from_fd 2.31% 4.35% 8.30% 0.00% 0.00% N/A
0.00% 2.96% 0.00% 1.30% 2.22% ls ld-2.29.so [.] __GI___tunables_init 0.00% 2.96% 0.00% 1.30% 2.22% N/A
0.66% 0.22% 0.68% 0.00% 0.21% ls ld-2.29.so [.] _dl_start 0.66% 0.22% 0.68% 0.00% 0.21% N/A
2.42% 0.00% 0.02% 3.16% 0.00% ls [unknown] [k] 0xffffffffa2a012b0 2.42% 0.00% 0.02% 3.16% 0.00% N/A
0.16% 0.00% 0.01% 0.20% 0.00% ls ld-2.29.so [.] _start 0.16% 0.00% 0.01% 0.20% 0.00% N/A
0.00% 0.00% 11.47% 0.00% 0.00% ls libcap.so.2.26 [.] 0x0000000000002420 0.00% 0.00% 11.47% 0.00% 0.00% N/A
0.00% 0.00% 10.50% 0.00% 0.00% ls libc-2.29.so [.] __GI___tcgetattr 0.00% 0.00% 10.50% 0.00% 0.00% N/A
0.00% 0.00% 9.14% 0.00% 0.00% ls ls [.] 0x000000000000767a 0.00% 0.00% 9.14% 0.00% 0.00% N/A
13.60% 0.00% 7.14% 2.31% 0.00% ls ld-2.29.so [.] _dl_relocate_object 13.60% 0.00% 7.14% 2.31% 0.00% N/A
2.13% 0.00% 6.14% 0.00% 0.00% ls ld-2.29.so [.] _dl_map_object_deps 2.13% 0.00% 6.14% 0.00% 0.00% N/A
0.00% 0.00% 5.27% 0.00% 0.00% ls ld-2.29.so [.] strlen 0.00% 0.00% 5.27% 0.00% 0.00% N/A
1.31% 0.00% 2.37% 1.08% 0.00% ls ld-2.29.so [.] _dl_sysdep_start 1.31% 0.00% 2.37% 1.08% 0.00% N/A
jirka
next prev parent reply other threads:[~2019-12-18 7:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 2:24 [PATCH v4 1/3] perf report: Change sort order by a specified event in group Jin Yao
2019-12-18 2:24 ` [PATCH v4 2/3] perf report: Support a new key to reload the browser Jin Yao
2019-12-18 2:24 ` [PATCH v4 3/3] perf report: support hotkey to let user select any event for sorting Jin Yao
2019-12-18 7:47 ` Jiri Olsa [this message]
2019-12-19 1:14 ` Jin, Yao
2019-12-19 5:10 ` Jin, Yao
2019-12-18 7:43 ` [PATCH v4 1/3] perf report: Change sort order by a specified event in group Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218074708.GC19062@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox