From: Jason Gunthorpe <jgg@ziepe.ca>
To: Max Hirsch <max.hirsch@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Parav Pandit <parav@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
Steve Wise <swise@opengridcomputing.com>,
Bart Van Assche <bvanassche@acm.org>,
Danit Goldberg <danitg@mellanox.com>,
Matthew Wilcox <willy@infradead.org>,
Dag Moxnes <dag.moxnes@oracle.com>,
Myungho Jung <mhjungk@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cma: Fix checkpatch error
Date: Wed, 18 Dec 2019 08:52:57 -0400 [thread overview]
Message-ID: <20191218125257.GD17227@ziepe.ca> (raw)
In-Reply-To: <CADgTo880aSn++fcf_rt0+8DCE4Y=xgXtZxFx9B0nzM_M1HdWPw@mail.gmail.com>
On Wed, Dec 11, 2019 at 08:33:10PM -0500, Max Hirsch wrote:
> Thanks for the quick response. This is my first patch, so I want to
> follow the correct protocol. I reran checkpatch after making the
> changes and there were no errors or warnings in the region I changed.
You are supposed to run the patch itself through checkpatch:
$ git format-patch HEAD^!
0001-RDMA-cma-Fix-checkpatch-error.patch
$ scripts/checkpatch.pl 0001-RDMA-cma-Fix-checkpatch-error.patch
WARNING: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] RDMA/cma: Fix checkpatch error
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
This patch moves the assignment of ret to the previous line. The if statement then checks the value of ret assigned on the previous line. The assigned value of ret is not changed. Testing involved recompiling and loading the kernel. After the changes checkpatch does not report this the error in cma.c.
total: 0 errors, 2 warnings, 9 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-RDMA-cma-Fix-checkpatch-error.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Jason
next prev parent reply other threads:[~2019-12-18 12:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 11:16 [PATCH] RDMA/cma: Fix checkpatch error Max Hirsch
2019-12-11 16:26 ` Jason Gunthorpe
2019-12-12 1:33 ` Max Hirsch
2019-12-18 12:52 ` Jason Gunthorpe [this message]
2019-12-12 8:49 ` Leon Romanovsky
2019-12-12 12:10 ` Gal Pressman
2019-12-12 12:28 ` Max Hirsch
2019-12-12 13:47 ` Leon Romanovsky
2019-12-12 13:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218125257.GD17227@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=dag.moxnes@oracle.com \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=max.hirsch@gmail.com \
--cc=mhjungk@gmail.com \
--cc=parav@mellanox.com \
--cc=swise@opengridcomputing.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox