From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E5C3C43603 for ; Wed, 18 Dec 2019 14:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A1BC21582 for ; Wed, 18 Dec 2019 14:46:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbfLROqF (ORCPT ); Wed, 18 Dec 2019 09:46:05 -0500 Received: from foss.arm.com ([217.140.110.172]:48712 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726921AbfLROqF (ORCPT ); Wed, 18 Dec 2019 09:46:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88F2430E; Wed, 18 Dec 2019 06:46:04 -0800 (PST) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDF753F719; Wed, 18 Dec 2019 06:46:02 -0800 (PST) Date: Wed, 18 Dec 2019 14:45:55 +0000 From: Sudeep Holla To: Jolly Shah Cc: ard.biesheuvel@linaro.org, mingo@kernel.org, gregkh@linuxfoundation.org, matt@codeblueprint.co.uk, hkallweit1@gmail.com, keescook@chromium.org, dmitry.torokhov@gmail.com, michal.simek@xilinx.com, rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface Message-ID: <20191218144555.GA12525@bogus> References: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote: > This patch series adds xilinx specific sysfs interface for below > purposes: > - Register access > - Set shutdown scope > - Set boot health status bit This series defeats the whole abstraction EEMI provides. By providing direct register accesses, you are allowing user-space to do whatever it wants. I had NACKed this idea before. Has anything changed ? If you need it for testing firmware, better put them in debugfs which is off on production builds. -- Regards, Sudeep