public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chan Shu Tak, ALex" <alexchan@task.com.hk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] llc2: Remove the condition operator in llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test_c.
Date: Wed, 18 Dec 2019 23:07:37 +0800	[thread overview]
Message-ID: <20191218150737.GA5800@rhel76> (raw)
In-Reply-To: <20191217.221846.1864258542284733289.davem@davemloft.net>

On Tue, Dec 17, 2019 at 10:18:46PM -0800, David Miller wrote:
> From: "Chan Shu Tak, Alex" <alexchan@task.com.hk>
> Date: Tue, 17 Dec 2019 12:00:36 +0800
> 
> > @@ -32,7 +32,7 @@ static int llc_stat_ev_rx_null_dsap_xid_c(struct sk_buff *skb)
> >  	return LLC_PDU_IS_CMD(pdu) &&			/* command PDU */
> >  	       LLC_PDU_TYPE_IS_U(pdu) &&		/* U type PDU */
> >  	       LLC_U_PDU_CMD(pdu) == LLC_1_PDU_CMD_XID &&
> > -	       !pdu->dsap ? 1 : 0;			/* NULL DSAP value */
> > +	       !pdu->dsap;				/* NULL DSAP value */
> 
> This isn't a v2 of your patch, it's a patch against v1 of your patch.
> 
> Please do this properly, thank you.

Thanks for your comments and patience and sorry for the troubles that I caused.

I will revise my patch and try again.

In this case, should I start anew or continue on this thread? 

Thanks again for your time.


  reply	other threads:[~2019-12-18 15:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-14 16:26 [PATCH] llc2: Reverse the true/false statements of the condition operator in llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test_c Chan Shu Tak, Alex
2019-12-17  0:26 ` David Miller
2019-12-17  4:00 ` [PATCH v2] llc2: Remove " Chan Shu Tak, Alex
2019-12-18  6:18   ` David Miller
2019-12-18 15:07     ` Chan Shu Tak, ALex [this message]
2019-12-18 20:24       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218150737.GA5800@rhel76 \
    --to=alexchan@task.com.hk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox